Skip to content

fix: monitor filter state syncing [ENG-2401] #7239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
speaker-ender wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: monitor filter state syncing [ENG-2401] #7239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee09f73
fix: monitor filter state syncing
speaker-ender Jan 16, 2026
aa39764
chore: adding changelog entry
speaker-ender Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/7239.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Copy this file and rename it (e.g., pr-number.yaml or feature-name.yaml)
# Fill in the required fields and delete this comment block

type: Fixed # One of: Added, Changed, Developer Experience, Deprecated, Docs, Fixed, Removed, Security
description: Fixed monitor filter state syncing
pr: 7239 # PR number
labels: [] # Optional: ["high-risk", "db-migration"]
44 changes: 10 additions & 34 deletions ...ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const CONFIDENCE_BUCKETS: ConfidenceBucket[] = [
ConfidenceBucket.MEDIUM,
ConfidenceBucket.LOW,
ConfidenceBucket.MANUAL,
];
] as const;

/**
* Build a nested tree structure from flat data category strings.
Expand Down Expand Up @@ -276,35 +276,17 @@ export const MonitorFieldFilters = ({
];

// Get current checked keys from LOCAL state
const checkedKeys = useMemo(
() =>
uniq([
...(localResourceStatus ?? []),
...(localDataCategory ?? []),
...(localConfidenceBucket ?? []),
]),
[localResourceStatus, localDataCategory, localConfidenceBucket],
);
const checkedKeys = uniq([
...(localResourceStatus ?? []),
...(localDataCategory ?? []),
...(localConfidenceBucket ?? []),
]);

// Calculate active filters count from APPLIED state (not local)
const activeFiltersCount = useMemo(() => {
let count = 0;
if (resourceStatus) {
// Deduplicate to get accurate count
count += new Set(resourceStatus).size;
}
if (dataCategory) {
// Deduplicate to get accurate count
count += new Set(dataCategory).size;
}

if (confidenceBucket) {
// Deduplicate to get accurate count
count += new Set(confidenceBucket).size;
}

return count;
}, [resourceStatus, dataCategory, confidenceBucket]);
const activeFiltersCount =
new Set(resourceStatus || []).size +
new Set(dataCategory || []).size +
new Set(confidenceBucket || []).size;

const handleCheck = (
checked: React.Key[] | { checked: React.Key[]; halfChecked: React.Key[] },
Expand Down Expand Up @@ -401,13 +383,7 @@ export const MonitorFieldFilters = ({
if (open) {
// When popover opens, refetch data categories to ensure they're up-to-date
refetchDatastoreFilters();
return;
}

// When popover closes without applying, reset local state to match applied state
setLocalResourceStatus(resourceStatus);
setLocalConfidenceBucket(confidenceBucket);
setLocalDataCategory(dataCategory);
};

return (
Expand Down
Loading