Create airframe config for EZG #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
force-pushed
the
pr-ezg-params
branch
from
860c4e9 to
33b2a45
Compare
acfloria
requested changes
Nov 10, 2021
| param set-default FW_AIRSPD_MAX 16.0 | ||
| param set-default FW_AIRSPD_MIN 8.5 | ||
| param set-default FW_AIRSPD_TRIM 10.0 | ||
| param set-default FW_DTRIM_P_VMAX -0.25 |
There was a problem hiding this comment.
I would not set the dtrim by default because they are platform specific
| param set-default LND_FLIGHT_T_HI 2 | ||
| param set-default LND_FLIGHT_T_LO -1126687183 | ||
| param set-default NPFG_GSP_MAX_TK 5.0 | ||
| param set-default NPFG_SW_DST_MLT0.5 |
There was a problem hiding this comment.
I think there is a space missing here
| param set-default PWM_MAIN_DIS5 -1 | ||
| param set-default PWM_MAIN_DIS6 -1 | ||
| param set-default PWM_MAIN_DISARM 1000 | ||
| param set-default PWM_MAIN_TRIM1 0.0 |
There was a problem hiding this comment.
The same for the trims. They are platform specific and probably should just be 0 by default
| param set-default ASPD_SCALE 0.85 | ||
|
|
||
| param set-default PWM_MAIN_DIS1 1500 | ||
| param set-default PWM_MAIN_DIS2 1350 |
There was a problem hiding this comment.
Probably the default here should be 1500. For this EZG we set it to 1350 because the actuator was not well centered.
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Previously, the parameters for EZGs were stored as a raw param file, making it hard to version the parameter files. Also, this makes it hard to match the parameter with the firmware version.
Describe your solution
This PR adds the parameters of our current EZGs to the airframe config.