Fix condor history logging and expose CPU/GPU usage in report UI#108
Draft
Copilot wants to merge 2 commits intov0.8-previewfrom
Draft
Fix condor history logging and expose CPU/GPU usage in report UI#108Copilot wants to merge 2 commits intov0.8-previewfrom
Copilot wants to merge 2 commits intov0.8-previewfrom
Conversation
…port UI and tests Co-authored-by: transientlunatic <4365778+transientlunatic@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix condor history logging functionality
Fix condor history logging and expose CPU/GPU usage in report UI
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect_historywas entirely broken: the happy path (named scheduler found) never calledhistory()or returned a value, and the fallback path consumed the job iterator withlist(jobs)before iterating it. Profiling data was also never surfaced in the report UI.Changes
asimov/scheduler.py— scheduler interfacecollect_history(cluster_id)as an abstract method onSchedulerHTCondor: queries the configured schedd first, falls back to all locatable schedds; converts results to{"end", "cpus", "gpus", "runtime"}dict_HISTORY_CLASSADSconstant and_datetime_from_epochhelper to module scopeRequestGpusto the classad projection (was absent); fixed GPU default fallback from1→0NotImplementedErrorstub inSlurmasimov/condor.py— fix and delegateReplaced the broken hand-rolled implementation with a clean delegation to
HTCondorScheduler.collect_history:asimov/monitor_states.py— remove over-restrictive guardDropped the
config.get("condor", "scheduler")check that silently skipped history collection whenever no named scheduler was configured. Any reachable schedd now suffices.asimov/event.py— emit profiling attributesAdded
get_profiling_attrs(node)helper that readsnode.meta["profiling"]and emitsdata-profiling-runtime,data-profiling-cpus,data-profiling-gpus,data-profiling-endon the hidden data<div>for both DAG and non-DAG render paths.asimov/cli/report.py— "Resource Usage" modal sectionAdded a collapsible table to the analysis modal displaying:
Xh Ym Zs)cpus × runtime)gpus × runtime, hidden when GPUs = 0)The section is hidden entirely when no profiling data is present.
tests/test_condor.py— new testsFive new tests covering: successful retrieval from configured schedd, fallback to secondary schedds,
ValueErrorwhen nothing found,RequestCpus/RequestGpusfallback, andcondor.collect_historydelegation.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.