-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor event rendering and improve graph data generation #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
transientlunatic
wants to merge
1
commit into
v0.7-preview
Choose a base branch
from
workflow-graph
base: v0.7-preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "name": "asimov-report-js", | ||
| "version": "1.0.0", | ||
| "private": true, | ||
| "description": "Bundled Mermaid + ELK for asimov HTML reports (air-gapped)", | ||
| "scripts": { | ||
| "build": "webpack" | ||
| }, | ||
| "dependencies": { | ||
| "@mermaid-js/layout-elk": "^0.1.0", | ||
| "mermaid": "^11.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "webpack": "^5.0.0", | ||
| "webpack-cli": "^5.0.0" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import mermaid from 'mermaid'; | ||
| import elkLayouts from '@mermaid-js/layout-elk'; | ||
|
|
||
| mermaid.registerLayoutLoaders(elkLayouts); | ||
|
|
||
| mermaid.initialize({ | ||
| startOnLoad: false, // we call mermaid.render() manually after page load | ||
| securityLevel: 'loose', // required for click handlers in diagram definitions | ||
| flowchart: { | ||
| defaultRenderer: 'elk', | ||
| }, | ||
| theme: 'base', | ||
| themeVariables: { | ||
| primaryTextColor: '#24292e', | ||
| lineColor: '#586069', | ||
| }, | ||
| }); | ||
|
|
||
| window.mermaid = mermaid; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| const path = require('path'); | ||
| const webpack = require('webpack'); | ||
|
|
||
| module.exports = { | ||
| mode: 'production', | ||
| entry: './src/index.js', | ||
| output: { | ||
| path: path.resolve(__dirname, '../static'), | ||
| filename: 'mermaid-elk.bundle.js', | ||
| }, | ||
| plugins: [ | ||
| // Force everything (including Mermaid's dynamic imports) into a single | ||
| // file so reports work from any path without managing multiple chunk URLs. | ||
| new webpack.optimize.LimitChunkCountPlugin({ maxChunks: 1 }), | ||
| ], | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mermaid is initialized with
securityLevel: 'loose', which relaxes sanitization and increases the impact of any untrusted content included in diagram definitions (e.g., analysis names or pipeline names). If any of that content can come from outside trusted sources, consider stricter settings and/or sanitizing labels before they reach Mermaid.