Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an initialization issue that caused asimov init Project to fail.
Changes:
- Fixed typo in PR description ("casued" → "caused")
- Updated test file paths to use "analyses" instead of hardcoded legacy directory names
- Added comprehensive test coverage for new features including project management, monitor helpers, and optional dependencies
Reviewed changes
Copilot reviewed 122 out of 130 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_project.py | New test file for Project Python API with context manager support |
| tests/test_pipelines/test_lalinference.py | Updated git add paths to use "analyses" directory |
| tests/test_pipelines/test_bayeswave.py | Updated git add paths and DAG file paths to use "analyses" directory |
| tests/test_pesummary_subject_analysis.py | New test file for PESummary as SubjectAnalysis functionality |
| tests/test_optional_dependencies.py | New test file for optional dependency handling |
| tests/test_monitor_helpers.py | New test file for monitor helper functions |
| tests/test_monitor_api.py | New test file for programmatic monitor API |
| tests/test_logging.py | New test file for logging interface improvements |
| tests/test_html_report.py | New test file for HTML report generation improvements |
| tests/test_data/*.yaml | New test data files for strategy and event testing |
| tests/test_blueprints/*.yaml | New blueprint test files for various pipelines |
| tests/test_blueprints.py | New basic test for blueprints module importability |
| tests/test_asimov.py | Updated to use importlib.metadata instead of pkg_resources |
| tests/test_application.py | Added strategy expansion tests |
| tests/test_analysis.py | Added cleanup to remove tmp directory before test setup |
| tests/mock_gwdatafind_server.py | New mock server for gwdatafind testing |
| tests/manual_test_priors.py | New manual integration test for prior system |
| tests/integration/test_gwtc2d1.py | Updated to use "analyses" directory |
| tests/integration/GW190426190642.yaml | Updated calibration and PSD paths to use "analyses" |
| tests/test_cli_manage.py | Updated file existence checks to use "analyses" directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which casued
asimov init Projectto fail.