CMake support by mtaillefumier · Pull Request #664 · etmc/tmLQCD

mtaillefumier · 2026-02-05T15:12:23Z

tmlQCD can be compiled with CMake. So far the build supports

mtaillefumier · 2026-02-05T15:16:40Z

@kostrzewa and @chaoos :

I reorganized the source tree and moved all library files in src/lib and executable in src/bin. Other layouts can be used
Compilation fails for some of the tests for instance test_locallity.c.

cmake/git_hash.h.in

cmake/tmlqcd_config_internal.h.in

src/bin/tests/test_lemon.c

profiling/hmc/example_profile.pdf

CMakeLists.txt

kostrzewa · 2026-02-07T12:12:29Z

@kottnad @chaoos in preparation for the discussion it would be great if you could give this a look and see if there are things where we should use the opportunity to do them differently

chaoos

Even with the changes from my suggestions below, the build still fails for me with various compiler errors and warnings, like e.g.:

/home/roman/projects/tmp/tmLQCD/src/lib/io/gauge_read_binary.c: In function ‘read_binary_gauge_data’:
/home/roman/projects/tmp/tmLQCD/src/lib/io/gauge_read_binary.c:72:17: error: ‘g_cart_grid’ undeclared (first use in this function); did you mean ‘g_cart_id’?
   72 |     MPI_Barrier(g_cart_grid);
      |                 ^~~~~~~~~~~
      |                 g_cart_id
/home/roman/projects/tmp/tmLQCD/src/lib/io/gauge_read_binary.c:72:17: note: each undeclared identifier is reported only once for each function it appears in
/home/roman/projects/tmp/tmLQCD/src/lib/io/utils_construct_writer.c: In function ‘construct_writer’:
/home/roman/projects/tmp/tmLQCD/src/lib/io/utils_construct_writer.c:17:28: error: ‘g_cart_grid’ undeclared (first use in this function); did you mean ‘g_cart_id’?
   17 |     status = MPI_File_open(g_cart_grid, filename,
      |                            ^~~~~~~~~~~
      |                            g_cart_id

One can put these variables as extern, but then at link time it fail to resolve with undefined reference to g_cart_grid'`.

CMakeLists.txt

src/lib/CMakeLists.txt

CMakeLists.txt

chaoos · 2026-02-12T10:00:23Z

Even with the changes from my suggestions below, the build still fails for me with various compiler errors and warnings, like e.g.:

/home/roman/projects/tmp/tmLQCD/src/lib/io/gauge_read_binary.c: In function ‘read_binary_gauge_data’:
/home/roman/projects/tmp/tmLQCD/src/lib/io/gauge_read_binary.c:72:17: error: ‘g_cart_grid’ undeclared (first use in this function); did you mean ‘g_cart_id’?
   72 |     MPI_Barrier(g_cart_grid);
      |                 ^~~~~~~~~~~
      |                 g_cart_id
/home/roman/projects/tmp/tmLQCD/src/lib/io/gauge_read_binary.c:72:17: note: each undeclared identifier is reported only once for each function it appears in
/home/roman/projects/tmp/tmLQCD/src/lib/io/utils_construct_writer.c: In function ‘construct_writer’:
/home/roman/projects/tmp/tmLQCD/src/lib/io/utils_construct_writer.c:17:28: error: ‘g_cart_grid’ undeclared (first use in this function); did you mean ‘g_cart_id’?
   17 |     status = MPI_File_open(g_cart_grid, filename,
      |                            ^~~~~~~~~~~
      |                            g_cart_id

One can put these variables as extern, but then at link time it fail to resolve with undefined reference to g_cart_grid'`.

Apologies, if I build lemon with the new cmake system as static library, I can build tmlqcd properly.

mtaillefumier · 2026-02-12T10:09:20Z

Sorry, the current version does not support the lemon configure build as the lemon cmake build system makes this more reliable. I need to check if I generate a pkg-config file for lemon

CMakeLists.txt

kostrzewa · 2026-02-13T09:17:54Z

CMakeLists.txt

+endif()
+
+# check for fftw3 (rely on pkgconfig).
+if(TM_USE_FFTW)


@kostrzewa check if FFTW still needed

CMakeLists.txt

kostrzewa · 2026-02-13T09:28:30Z

remove LAPH_ev.c

kostrzewa · 2026-02-13T09:34:39Z

src/lib/CMakeLists.txt

+set_target_properties(hmc PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION 1)
+
+# define a library and add the dependencies
+target_link_libraries(


@kostrzewa test if this works with CVC

src/lib/CMakeLists.txt

kostrzewa · 2026-02-13T09:48:50Z

please add a couple of example cmake calls to a doc/cmake-examples directory

src/lib/DDalphaAMG_interface.h

CMakeLists.txt

kostrzewa · 2026-03-27T06:52:49Z

I'm afraid some compilation paths have been broken. For example,

-DTM_USE_HALFSPINOR=OFF

does not compile because the hopping.h header has disappeared from src/lib/operator.

kostrzewa · 2026-03-27T06:54:49Z

This happened during e591af5 and I think hopping.h was mangled before that during the SSE / BGL / XLC removal.

See hopping.h at state https://github.com/etmc/tmLQCD/blob/b4f5fbba6cded50237b8ee8507beec1d247b08e5/operator/hopping.h -> #else branch.

kostrzewa · 2026-03-27T07:02:05Z

We could add an additional github workflow which builds (but does not run) a set of compilation flag combinations.

mtaillefumier · 2026-03-27T08:11:30Z

-DTM_USE_HALFSPINOR=OFF is working now

- Restored hopping.h - Rename hmc with tmlqcd - Fix TM_USE_DDalphaAMG when necessary - Remove header guards in git_hash.c

Co-authored-by: chaoos <chaoos@users.noreply.github.com>

- Restored hopping.h - Rename hmc with tmlqcd - Fix TM_USE_DDalphaAMG when necessary - Remove header guards in git_hash.c - Update Spack package

…ge.py Co-authored-by: chaoos <chaoos@users.noreply.github.com>

mtaillefumier · 2026-03-27T09:28:14Z

@kostrzewa: I removed the duplicated file hopping_body_dbl.c and the comment in 'src/lib/xchange/xchange_halffield.c'. Unfortunately I force pushed which mean the commit you commented out is still there with a different reference.

kostrzewa · 2026-03-27T10:04:25Z

It would be great if we could try to avoid force-pushes if possible.

For example the work in #666 has been based on cmake_support and I worry that there will be some issues when the PTBC stuff becomes ready to be tested.

kostrzewa · 2026-03-27T10:15:17Z

Note that in tm_[sub,times]_Hopping_Matrix.c the current head commit here still refers to hopping_body_dbl.c instead of hopping_body_dbl.inc.

Regarding your comment about the insertion of halfspinor_body.inc and hopping_body_dbl.inc I agree that it's not the prettiest solution but it does enable three variations (which are essentiallly kernel fusions)

Hopping_Matrix.c, tm_sub_Hopping_Matrix.c and tm_times_Hopping_Matrix.c to be implemented without code duplication.

…ing_body_dbl.inc

mtaillefumier · 2026-03-27T13:22:53Z

Note that in tm_[sub,times]_Hopping_Matrix.c the current head commit here still refers to hopping_body_dbl.c instead of hopping_body_dbl.inc.

Regarding your comment about the insertion of halfspinor_body.inc and hopping_body_dbl.inc I agree that it's not the prettiest solution but it does enable three variations (which are essentiallly kernel fusions)

Hopping_Matrix.c, tm_sub_Hopping_Matrix.c and tm_times_Hopping_Matrix.c to be implemented without code duplication.

can we reach this with inlining. I may not want to include this in this PR though. I modified the last remaning file as well

kostrzewa · 2026-03-27T13:32:11Z

can we reach this with inlining. I may not want to include this in this PR though.

let's not include it here

I modified the last remaning file as well

okay, should I close the corresponding PR then? #672

kostrzewa · 2026-03-27T13:37:57Z

I'm going to continue testing the build on different machines. It will take a few days but I would like to complete this before easter as the teaching period starts again on the 13th of April and I'll have too much to do then...

mtaillefumier · 2026-03-27T14:27:20Z

can we reach this with inlining. I may not want to include this in this PR though.

let's not include it here

I modified the last remaning file as well

okay, should I close the corresponding PR then? #672

[ignore] Actually it might be better to merge your PR first and then I can rebase afterwards. This fix needs to be applied to the last version as well.

I merged your PR and I will fix potential conflicts. I need to check that I did not delete the hopping.h file in the "old" tree.

include hopping.h and hoping_body_dbl.inc in tm_[sub,times]_Hopping_Matrix.c

mtaillefumier · 2026-03-27T14:37:45Z

@chaoos @kostrzewa

A short recap of changes

Restored invert.c
Restored hopping.h
Fix compilation issue with HALF_SPINOR is OFF
Fix TM_USE_DDalphaAMG
Renamed hmc to tmlqcd (small caps)
Remove unnecessary comments
create a tag for lemon and update the Spack package
check that hopping.h is present in the old build system

mtaillefumier · 2026-03-27T14:45:39Z

i opened a PR in the lemon github repo updating the version to 1.2.0. I can either merge it manually and then create the tag accordingly or let someone else do it

kostrzewa · 2026-03-27T14:59:35Z

check that hopping.h is present in the old build system

no it's not, we should probably also restore it there and then tag that as rel-6-0-2

the cmake_support branch will then become rel-6-1-0

mtaillefumier · 2026-03-27T15:01:18Z

check that hopping.h is present in the old build system

no it's not, we should probably also restore it there and then tag that as rel-6-0-2

the cmake_support branch will then become rel-6-1-0

I am already working on it. I will open a PR in a short while.

mtaillefumier · 2026-03-27T15:09:05Z

Pr opened to fix hopping.h. Once merged I will rebase this PR from the master branch.

mtaillefumier force-pushed the cmake_support branch from cc527c1 to c86f934 Compare February 5, 2026 15:33

kostrzewa reviewed Feb 7, 2026

View reviewed changes

cmake/git_hash.h.in Outdated Show resolved Hide resolved

kostrzewa reviewed Feb 7, 2026

View reviewed changes

cmake/tmlqcd_config_internal.h.in Outdated Show resolved Hide resolved

kostrzewa reviewed Feb 7, 2026

View reviewed changes

src/bin/tests/test_lemon.c Show resolved Hide resolved

kostrzewa reviewed Feb 7, 2026

View reviewed changes

profiling/hmc/example_profile.pdf Show resolved Hide resolved

kostrzewa reviewed Feb 7, 2026

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

mtaillefumier force-pushed the cmake_support branch 3 times, most recently from 2d50b54 to 8f39dd2 Compare February 11, 2026 07:58

chaoos previously requested changes Feb 11, 2026

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

src/lib/CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved