Skip to content

Fixed bug in quda_interface.c#670

Merged
kostrzewa merged 1 commit intomasterfrom
konstantin_devel
Mar 18, 2026
Merged

Fixed bug in quda_interface.c#670
kostrzewa merged 1 commit intomasterfrom
konstantin_devel

Conversation

@kottnad
Copy link
Copy Markdown
Contributor

@kottnad kottnad commented Mar 10, 2026

If-statement had no effect due to setting first_call = 1 in first branch, i.e. freeCloverQuda() was never called.

…ng first_call = 1, i.e. freeCloverQuda() was never called.
@kostrzewa
Copy link
Copy Markdown
Member

cscs-ci run default

@kostrzewa
Copy link
Copy Markdown
Member

As discussed offline, this should be inconsequential because of the logic within QUDA and because:

  1. our clover term is independent of tm_rho (our Hasenbusch mass precon mass)
  2. Mu2() (mu squared) changes as we move between the ND heavy doublet and the various monomials of the degenerate light doublet

Still, it probably is safer to use our own logic for invalidating the clover field because we are then independent of whatever might happen on the QUDA side.

@kostrzewa kostrzewa self-requested a review March 18, 2026 09:42
@kostrzewa kostrzewa merged commit 2fbab87 into master Mar 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants