Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dependency_injector/providers.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -3221,8 +3221,8 @@ cdef class ThreadLocalSingleton(BaseSingleton):
return future_result

self._storage.instance = instance
finally:
return instance

return instance

def _async_init_instance(self, future_result, result):
try:
Expand Down
20 changes: 20 additions & 0 deletions tests/unit/providers/singleton/test_thread_local_singleton_py3.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import pytest

from dependency_injector.containers import Container
from dependency_injector.providers import ThreadLocalSingleton


class FailingClass:
def __init__(self):
raise ValueError("FAILING CLASS")


class TestContainer(Container):
failing_class = ThreadLocalSingleton(FailingClass)


def test_on_failure_value_error_is_raised():
container = TestContainer()

with pytest.raises(ValueError, match="FAILING CLASS"):
container.failing_class()
Loading