Docs/grammar fix providers-singleton, issue #917 #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZipFile
reviewed
Aug 12, 2025
| @@ -33,8 +33,8 @@ factories: | |||
| - :ref:`factory-specialize-provided-type` | |||
| - :ref:`abstract-factory` | |||
|
|
|||
| ``Singleton`` provider scope is tied to the container. Two different containers will provider | |||
| two different singleton objects: | |||
| Since ``Singleton`` scope is container-specific, each container will create and manage its own ``Singleton`` instance. | |||
There was a problem hiding this comment.
I'm not sure this has the same meaning as before now. Since usage assumes we previously mentioned scope in relation to container. Which we did not.
There was a problem hiding this comment.
Thought i would add some clarity but if the meaning has totally shifted, then i will stick with just fixing the typo on the previous sentence.
There was a problem hiding this comment.
So should i just make a pull request with the grammer correction for now ?
There was a problem hiding this comment.
You can do it within this PR, I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clarity and minor fixes on the singleton documentation.