Merge pull request #5 from eugener/develop

refactor: replace hardcoded /tmp paths with OS-agnostic temp directories

Author: eugener

README.md

@@ -854,7 +854,7 @@ cargo run --example error_handling
 - **`commit_history.rs`** - Comprehensive commit history & log operations showing all querying APIs, filtering, analysis, and advanced LogOptions usage
 - **`error_handling.rs`** - Comprehensive error handling patterns showing GitError variants, recovery strategies, and best practices
 
-All examples use temporary directories in `/tmp/` and include automatic cleanup for safe execution.
+All examples use OS-appropriate temporary directories and include automatic cleanup for safe execution.
 
 ## Testing
 
@@ -864,7 +864,7 @@ Run the test suite:
 cargo test
 ```
 
-All tests create temporary repositories in `/tmp/` and clean up after themselves.
+All tests create temporary repositories in OS-appropriate temporary directories and clean up after themselves.
 
 ## Contributing
 

examples/basic_usage.rs

@@ -10,45 +10,45 @@
 //! Run with: cargo run --example basic_usage
 
 use rustic_git::{Repository, Result};
+use std::env;
 use std::fs;
-use std::path::Path;
 
 fn main() -> Result<()> {
     println!("Rustic Git - Basic Usage Example\n");
 
     // Use a temporary directory for this example
-    let repo_path = "/tmp/rustic_git_basic_example";
+    let repo_path = env::temp_dir().join("rustic_git_basic_example");
 
     // Clean up any previous run
-    if Path::new(repo_path).exists() {
-        fs::remove_dir_all(repo_path).expect("Failed to clean up previous example");
+    if repo_path.exists() {
+        fs::remove_dir_all(&repo_path).expect("Failed to clean up previous example");
     }
 
-    println!("Initializing new repository at: {}", repo_path);
+    println!("Initializing new repository at: {}", repo_path.display());
 
     // Initialize a new repository
-    let repo = Repository::init(repo_path, false)?;
+    let repo = Repository::init(&repo_path, false)?;
     println!("Repository initialized successfully\n");
 
     // Create some example files
     println!("Creating example files...");
-    fs::create_dir_all(format!("{}/src", repo_path))?;
+    fs::create_dir_all(repo_path.join("src"))?;
 
     fs::write(
-        format!("{}/README.md", repo_path),
+        repo_path.join("README.md"),
         "# My Awesome Project\n\nThis is a demo project for rustic-git!\n",
     )?;
 
     fs::write(
-        format!("{}/src/main.rs", repo_path),
+        repo_path.join("src/main.rs"),
         r#"fn main() {
     println!("Hello from rustic-git example!");
 }
 "#,
     )?;
 
     fs::write(
-        format!("{}/src/lib.rs", repo_path),
+        repo_path.join("src/lib.rs"),
         "// Library code goes here\npub fn hello() -> &'static str {\n    \"Hello, World!\"\n}\n",
     )?;
 
@@ -125,7 +125,7 @@ fn main() -> Result<()> {
 
     // Clean up
     println!("Cleaning up example repository...");
-    fs::remove_dir_all(repo_path)?;
+    fs::remove_dir_all(&repo_path)?;
     println!("Example completed successfully!");
 
     Ok(())

examples/branch_operations.rs

@@ -1,25 +1,20 @@
 use rustic_git::{Repository, Result};
-use std::fs;
-use std::path::Path;
+use std::{env, fs};
 
 fn main() -> Result<()> {
-    let test_path = "/tmp/rustic_git_branch_example";
+    let test_path = env::temp_dir().join("rustic_git_branch_example");
 
     // Clean up if exists
-    if Path::new(test_path).exists() {
-        fs::remove_dir_all(test_path).unwrap();
+    if test_path.exists() {
+        fs::remove_dir_all(&test_path).unwrap();
     }
 
     // Create a test repository
-    let repo = Repository::init(test_path, false)?;
-    println!("Created repository at: {}", test_path);
+    let repo = Repository::init(&test_path, false)?;
+    println!("Created repository at: {}", test_path.display());
 
     // Create initial commit so we have a valid HEAD
-    fs::write(
-        format!("{}/README.md", test_path),
-        "# Branch Operations Demo\n",
-    )
-    .unwrap();
+    fs::write(test_path.join("README.md"), "# Branch Operations Demo\n").unwrap();
     repo.add(&["README.md"])?;
     repo.commit("Initial commit")?;
     println!("Created initial commit");
@@ -61,7 +56,7 @@ fn main() -> Result<()> {
     println!("Created and checked out: {}", dev_branch.name);
 
     // Make a commit on the new branch
-    fs::write(format!("{}/feature.txt", test_path), "New feature code\n").unwrap();
+    fs::write(test_path.join("feature.txt"), "New feature code\n").unwrap();
     repo.add(&["feature.txt"])?;
     repo.commit("Add new feature")?;
     println!("Made commit on develop branch");
@@ -139,7 +134,7 @@ fn main() -> Result<()> {
     println!("\nFinal branch count: {}", final_branches.len());
 
     // Clean up
-    fs::remove_dir_all(test_path).unwrap();
+    fs::remove_dir_all(&test_path).unwrap();
     println!("\nCleaned up test repository");
 
     Ok(())

examples/commit_history.rs

@@ -1,26 +1,25 @@
 use chrono::{Duration, Utc};
 use rustic_git::{LogOptions, Repository, Result};
-use std::fs;
-use std::path::Path;
+use std::{env, fs};
 
 fn main() -> Result<()> {
-    let test_path = "/tmp/rustic_git_commit_history_example";
+    let test_path = env::temp_dir().join("rustic_git_commit_history_example");
 
     // Clean up if exists
-    if Path::new(test_path).exists() {
-        fs::remove_dir_all(test_path).unwrap();
+    if test_path.exists() {
+        fs::remove_dir_all(&test_path).unwrap();
     }
 
     // Create a test repository
-    let repo = Repository::init(test_path, false)?;
-    println!("Created repository at: {}", test_path);
+    let repo = Repository::init(&test_path, false)?;
+    println!("Created repository at: {}", test_path.display());
 
     // Create several commits to build history
     println!("\n=== Building Commit History ===");
 
     // First commit
     fs::write(
-        format!("{}/README.md", test_path),
+        test_path.join("README.md"),
         "# Commit History Demo\n\nA demonstration of rustic-git log functionality.",
     )
     .unwrap();
@@ -29,9 +28,9 @@ fn main() -> Result<()> {
     println!("Created commit 1: {} - Initial commit", commit1.short());
 
     // Second commit
-    fs::create_dir_all(format!("{}/src", test_path)).unwrap();
+    fs::create_dir_all(test_path.join("src")).unwrap();
     fs::write(
-        format!("{}/src/main.rs", test_path),
+        test_path.join("src/main.rs"),
         "fn main() {\n    println!(\"Hello, world!\");\n}",
     )
     .unwrap();
@@ -41,7 +40,7 @@ fn main() -> Result<()> {
 
     // Third commit
     fs::write(
-        format!("{}/src/lib.rs", test_path),
+        test_path.join("src/lib.rs"),
         "pub fn greet(name: &str) -> String {\n    format!(\"Hello, {}!\", name)\n}",
     )
     .unwrap();
@@ -51,7 +50,7 @@ fn main() -> Result<()> {
 
     // Fourth commit
     fs::write(
-        format!("{}/Cargo.toml", test_path),
+        test_path.join("Cargo.toml"),
         "[package]\nname = \"demo\"\nversion = \"0.1.0\"\nedition = \"2021\"",
     )
     .unwrap();
@@ -61,7 +60,7 @@ fn main() -> Result<()> {
 
     // Fifth commit - bug fix
     fs::write(
-        format!("{}/src/main.rs", test_path),
+        test_path.join("src/main.rs"),
         "fn main() {\n    println!(\"Hello, rustic-git!\");\n}",
     )
     .unwrap();
@@ -70,7 +69,7 @@ fn main() -> Result<()> {
     println!("Created commit 5: {} - Fix greeting", commit5.short());
 
     // Sixth commit - documentation
-    fs::write(format!("{}/README.md", test_path), "# Commit History Demo\n\nA demonstration of rustic-git log functionality.\n\n## Features\n\n- Greeting functionality\n- Command line interface\n").unwrap();
+    fs::write(test_path.join("README.md"), "# Commit History Demo\n\nA demonstration of rustic-git log functionality.\n\n## Features\n\n- Greeting functionality\n- Command line interface\n").unwrap();
     repo.add(&["README.md"])?;
     let commit6 = repo.commit("Update README with features section")?;
     println!("Created commit 6: {} - Update README", commit6.short());
@@ -292,7 +291,7 @@ fn main() -> Result<()> {
     println!("\n=== Summary ===");
 
     println!("Commit history demonstration completed!");
-    println!("  Repository: {}", test_path);
+    println!("  Repository: {}", test_path.display());
     println!("  Total commits analyzed: {}", all_commits.len());
     println!("  Hash examples:");
     for commit in all_commits.iter().take(3) {
@@ -301,7 +300,7 @@ fn main() -> Result<()> {
     }
 
     // Clean up
-    fs::remove_dir_all(test_path).unwrap();
+    fs::remove_dir_all(&test_path).unwrap();
     println!("\nCleaned up test repository");
 
     Ok(())

examples/commit_workflows.rs

@@ -10,45 +10,44 @@
 //! Run with: cargo run --example commit_workflows
 
 use rustic_git::{Hash, Repository, Result};
-use std::fs;
-use std::path::Path;
+use std::{env, fs};
 
 fn main() -> Result<()> {
     println!("Rustic Git - Commit Workflows Example\n");
 
-    let repo_path = "/tmp/rustic_git_commit_example";
+    let repo_path = env::temp_dir().join("rustic_git_commit_example");
 
     // Clean up any previous run
-    if Path::new(repo_path).exists() {
-        fs::remove_dir_all(repo_path).expect("Failed to clean up previous example");
+    if repo_path.exists() {
+        fs::remove_dir_all(&repo_path).expect("Failed to clean up previous example");
     }
 
     // Initialize repository
     println!("Setting up repository for commit demonstrations...");
-    let repo = Repository::init(repo_path, false)?;
+    let repo = Repository::init(&repo_path, false)?;
     println!("Repository initialized\n");
 
     println!("=== Basic Commit Operations ===\n");
 
     // Create initial files
     println!("Creating initial project files...");
-    fs::create_dir_all(format!("{}/src", repo_path))?;
+    fs::create_dir_all(repo_path.join("src"))?;
 
     fs::write(
-        format!("{}/README.md", repo_path),
+        repo_path.join("README.md"),
         "# Commit Demo Project\n\nThis project demonstrates commit workflows with rustic-git.\n",
     )?;
 
     fs::write(
-        format!("{}/src/main.rs", repo_path),
+        repo_path.join("src/main.rs"),
         r#"fn main() {
     println!("Hello, Commit Demo!");
 }
 "#,
     )?;
 
     fs::write(
-        format!("{}/Cargo.toml", repo_path),
+        repo_path.join("Cargo.toml"),
         r#"[package]
 name = "commit-demo"
 version = "0.1.0"
@@ -109,10 +108,10 @@ edition = "2021"
 
     // Create more files to commit with custom author
     println!("Adding features for custom author commit...");
-    fs::create_dir_all(format!("{}/tests", repo_path))?;
+    fs::create_dir_all(repo_path.join("tests"))?;
 
     fs::write(
-        format!("{}/src/lib.rs", repo_path),
+        repo_path.join("src/lib.rs"),
         r#"//! Commit demo library
 
 pub fn greet(name: &str) -> String {
@@ -132,7 +131,7 @@ mod tests {
     )?;
 
     fs::write(
-        format!("{}/tests/integration_test.rs", repo_path),
+        repo_path.join("tests/integration_test.rs"),
         r#"use commit_demo::greet;
 
 #[test]
@@ -166,7 +165,7 @@ fn test_integration() {
     // Commit 3: Update version
     println!("Step 1: Update version information...");
     fs::write(
-        format!("{}/Cargo.toml", repo_path),
+        repo_path.join("Cargo.toml"),
         r#"[package]
 name = "commit-demo"
 version = "0.2.0"
@@ -182,7 +181,7 @@ description = "A demo project for commit workflows"
     // Commit 4: Add documentation
     println!("Step 2: Add documentation...");
     fs::write(
-        format!("{}/CHANGELOG.md", repo_path),
+        repo_path.join("CHANGELOG.md"),
         r#"# Changelog
 
 ## [0.2.0] - 2024-01-01
@@ -210,7 +209,7 @@ description = "A demo project for commit workflows"
     // Commit 5: Final polish
     println!("Step 3: Final polish...");
     fs::write(
-        format!("{}/README.md", repo_path),
+        repo_path.join("README.md"),
         r#"# Commit Demo Project
 
 This project demonstrates commit workflows with rustic-git.
@@ -298,10 +297,7 @@ See CHANGELOG.md for version history.
     println!("\nTesting commit with empty message:");
 
     // Create a change to commit
-    fs::write(
-        format!("{}/temp_for_empty_message.txt", repo_path),
-        "temp content",
-    )?;
+    fs::write(repo_path.join("temp_for_empty_message.txt"), "temp content")?;
     repo.add(&["temp_for_empty_message.txt"])?;
 
     match repo.commit("") {
@@ -336,7 +332,7 @@ See CHANGELOG.md for version history.
 
     // Clean up
     println!("\nCleaning up example repository...");
-    fs::remove_dir_all(repo_path)?;
+    fs::remove_dir_all(&repo_path)?;
     println!("Commit workflows example completed!");
 
     Ok(())