Skip to content

BAEL-9323 #18723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions spring-batch-2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.graphql-java</groupId>
<artifactId>java-dataloader</artifactId>
<version>3.2.0</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done asynchronously, but let's pull this out to be a property, like the other dependencies.

Suggested change
<version>3.2.0</version>
<version>${java-dataloader.version}</version>

</dependency>
</dependencies>

<build>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package com.baeldung.dataloaderbatchprocessing;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
public class DataLoaderApp {

public static void main(String[] args) {
SpringApplication.run(DataLoaderApp.class, args);
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package com.baeldung.dataloaderbatchprocessing;

import org.dataloader.BatchLoader;
import org.dataloader.DataLoader;
import org.dataloader.DataLoaderFactory;
import org.springframework.stereotype.Component;

import java.util.Map;
import java.util.stream.Collectors;

import com.baeldung.dataloaderbatchprocessing.entity.User;
import com.baeldung.dataloaderbatchprocessing.service.UserService;

@Component
public class UserDataLoader {

private final UserService userService;

public UserDataLoader(UserService userService) {
this.userService = userService;
}

public DataLoader<String, User> createUserLoader() {
BatchLoader<String, User> userBatchLoader = ids -> {
return userService.getUsersByIds(ids)
.thenApply(users -> {
Map<String, User> userMap = users.stream()
.collect(Collectors.toMap(User::getId, user -> user));
return ids.stream()
.map(userMap::get)
.collect(Collectors.toList());
});
};

return DataLoaderFactory.newDataLoader(userBatchLoader);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package com.baeldung.dataloaderbatchprocessing.entity;

import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import lombok.AllArgsConstructor;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Entity
@Getter
@AllArgsConstructor
@NoArgsConstructor
public class User {

@Id
private String id;
private String name;
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.baeldung.dataloaderbatchprocessing.repository;

import org.springframework.data.jpa.repository.JpaRepository;

import com.baeldung.dataloaderbatchprocessing.entity.User;

public interface UserRepository extends JpaRepository<User, String> {
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package com.baeldung.dataloaderbatchprocessing.service;
import org.springframework.stereotype.Service;

import java.util.List;
import java.util.concurrent.CompletableFuture;

import com.baeldung.dataloaderbatchprocessing.entity.User;
import com.baeldung.dataloaderbatchprocessing.repository.UserRepository;

@Service
public class UserService {
private final UserRepository userRepository;

public UserService(UserRepository userRepository) {
this.userRepository = userRepository;
}

public CompletableFuture<List<User>> getUsersByIds(List<String> ids) {
return CompletableFuture.supplyAsync(() -> userRepository.findAllById(ids));
}
}

Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
package com.baeldung.dataloaderbatchprocessing;

import com.baeldung.dataloaderbatchprocessing.entity.User;
import com.baeldung.dataloaderbatchprocessing.service.UserService;

import org.dataloader.DataLoader;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.SpringBootTest;

import java.util.Arrays;
import java.util.List;
import java.util.concurrent.CompletableFuture;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.*;

@SpringBootTest(classes = DataLoaderApp.class)
public class DataLoaderUnitTest {

private UserService userService;
private UserDataLoader loaderFactory;

@BeforeEach
void setUp() {
userService = mock(UserService.class);
loaderFactory = new UserDataLoader(userService);
}

@Test
void givenThreeUsers_whenUsingDataLoader_thenLoadUsersInSingleDBCall() throws Exception {
User user1 = new User("101", "User_101");
User user2 = new User("102", "User_102");
User user3 = new User("103", "User_103");

List<User> users = Arrays.asList(user1, user2, user3);

when(userService.getUsersByIds(Arrays.asList("101", "102", "103"))).thenReturn(CompletableFuture.completedFuture(users));

DataLoader<String, User> userLoader = loaderFactory.createUserLoader();

CompletableFuture<User> future1 = userLoader.load("101");
CompletableFuture<User> future2 = userLoader.load("102");
CompletableFuture<User> future3 = userLoader.load("103");

userLoader.dispatch();

assertEquals("User_101", future1.get()
.getName());
assertEquals("User_102", future2.get()
.getName());
assertEquals("User_103", future3.get()
.getName());

verify(userService, times(1)).getUsersByIds(Arrays.asList("101", "102", "103"));
}
}