Skip to content

Commit f980ee9

Browse files
use .cash()
1 parent cc0bfcf commit f980ee9

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

TODO

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
* currently it's an arithmetic underflow
55
! Don't make quotes that would cause a swap to fail due to supply or borrow caps
66
! Use `myDebt() == 0` condition for disabling controller: more accurate
7-
! In _computeQuote() use vault.cash() method instead of token.balanceOf() otherwise donations could cause quoted swaps to fail
87
! In _computeQuote(), exactOut swaps should verify the *amount* (not quote) is withdrawable
98
* ConstantSum: incorporate price multipliers in quote methods
109
* natspec

src/MaglevBase.sol

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,7 @@ abstract contract MaglevBase is IMaglevBase, EVCUtil {
200200
uint256 quote = computeQuote(amount, exactIn, asset0IsInput);
201201

202202
require(quote <= (asset0IsInput ? reserve1 : reserve0), InsufficientReserves());
203-
require(
204-
quote <= IERC20(asset0IsInput ? asset1 : asset0).balanceOf(asset0IsInput ? vault1 : vault0),
205-
InsufficientCash()
206-
);
203+
require(quote <= IEVault(asset0IsInput ? vault1 : vault0).cash(), InsufficientCash());
207204

208205
// exactOut: increase required amountIn, rounding up
209206
if (!exactIn) quote = (quote * 1e18 + (feeMultiplier - 1)) / feeMultiplier;

0 commit comments

Comments
 (0)