add fixed cyclical binary irm

[dglowinski]

No description provided.

[immunefi-magnus]

🛡️ Immunefi PR Reviews

We’ve assigned 5 code reviewer(s) to this PR.

They’ll begin the review shortly and leave feedback directly in the pull request.

This review is based on the current state of your pull request. If you make changes after the review starts, they won’t be reflected here. To ensure the review includes your latest updates, you’ll need to open a new pull request.

[immunefi-magnus]

The PR looks good to me.

if (msg.sender != vault) revert E_IRMUpdateUnauthorized();

The vault parameter is being taken from a user-provided argument, which effectively bypasses the intended access control check. We believe this check may be unnecessary in its current form.

• Oxrudrapratap

[dglowinski]

The check for sender is just a convention we use in other IRMs, which signals that computeInterestRate is meant to be a potentially state mutating function called by the vaults, and reads should be directed at computeInterestRateView