Skip to content

Conversation

haeter525
Copy link
Member

@haeter525 haeter525 commented Apr 23, 2022

Description
Close #330.
This PR aims to

  1. remove the logic currently used to parse multiple Dex files.
  2. open APKs with a specified protocol to introduce the Multidex support of Rizin.

Test plan
All tests passed.

@pulorsok
Copy link
Member

Hi @haeter525
First of all, nice work on the Rizin integration!
Thanks for the contribution you made. It is a great milestone for us.

However, since our project wants to be more contributor friendly,
I suggest we edit documents for the functions in the codebase.
The documents give a short description of the function and how to use it.
And I think it also will help us to maintain the codebase.

For example:

def color(text, color_code):
  """Colorize text.
  @param text: text.
  @param color_code: color.
  @return: colorized text.
  """
  if sys.platform == "win32" and os.getenv("TERM") != "xterm":
    return text
  return "\x1b[%dm%s\x1b[0m" % (color_code, text)

@haeter525
Copy link
Member Author

haeter525 commented Apr 24, 2022

Thank @pulorsok for the nice suggestion. I've updated the docstring in #335.
Once we merge that PR, I will rebase the commits to ensure all methods here are well-documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completely support Multidex when analyzing with Rizin
2 participants