Skip to content

Conversation

sidra-asa
Copy link
Collaborator

@sidra-asa sidra-asa commented Jan 17, 2023

Description

Close #334.
This PR is based on #335 .
It aims to updates the Rizin-based analysis library to work with the current Rizin at the dev branch.
The current release is v0.5.x.
It includes the following changes -

  • Update parser for command axtj
  • Replace command axffj with pdfj and is.j since Rizin v0.4.x removed it.
  • Rewrite _get_method_by_address by using is.j to precisely find the method via a given address.
  • Add support to parse methods with variable-length arguments.
  • Refactor to use the same code to parse the output of isj and is.j.

Code Changes

  • quark/core/rzapkinfo.py
  • quark/utils/tools.py

Test Plans

All tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Attention: Patch coverage is 89.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.29%. Comparing base (b3a249b) to head (ee28adb).
Report is 102 commits behind head on master.

Files with missing lines Patch % Lines
quark/core/rzapkinfo.py 86.11% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   79.19%   79.29%   +0.09%     
==========================================
  Files          63       64       +1     
  Lines        4960     5008      +48     
==========================================
+ Hits         3928     3971      +43     
- Misses       1032     1037       +5     
Flag Coverage Δ
unittests 79.29% <89.28%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haeter525 haeter525 self-assigned this Jan 17, 2023
@haeter525 haeter525 linked an issue Jan 18, 2023 that may be closed by this pull request
@sidra-asa sidra-asa force-pushed the core_lib_rizin_0.5 branch from e500599 to 5823049 Compare June 6, 2023 08:50
@sidra-asa sidra-asa force-pushed the core_lib_rizin_0.5 branch from 5823049 to ee28adb Compare June 6, 2023 21:44
@sidra-asa sidra-asa changed the title Update analysis library for Rizin v0.5.x Update analysis library for Rizin v0.6.2 Oct 9, 2023
@sidra-asa sidra-asa changed the title Update analysis library for Rizin v0.6.2 Update analysis library for Rizin v0.5.x Oct 9, 2023
@sidra-asa
Copy link
Collaborator Author

Since the release version of Rizin is v0.6.2.
I will close this PR, and create another one for the core library upgrade.

@haeter525
Copy link
Member

Close this PR as we have #690.

@haeter525 haeter525 closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update analysis library for Rizin v0.5 Update analysis library for Rizin v0.4.x

3 participants