Return Rust structs from libmoonwave#181
Open
daimond113 wants to merge 2 commits intoevaera:masterfrom
Open
Conversation
Collaborator
|
Could we, in addition to the new api in the pull request, preserve the |
Author
|
I'm not opposed to it, but this PR already brings in breaking changes which makes me think re-adding that API might not be necessary. I will re-add it if it's still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, libmoonwave contained the CLI and was hardly useful since it printed to the console instead of returning Rust structs. This PR separates the CLI's dependencies into a feature and returns Rust structs from the parse functions.
Because of Rust's ownership rules, I had to separate
generate_docs_from_pathintoparse_source_files_at_pathandgenerate_docs_from_sources. Additionally, I made thefind_filesfunction public so that its error can be handled separately.