Open
Conversation
Still a little buggy.
Contributor
Author
|
By the way, I tested whether descendants of irrelevant directories would be watched by adding |
Contributor
Author
Quote from #189 (comment) I think I found it: moonwave/docusaurus-plugin-moonwave/src/index.js Lines 269 to 271 in 6b24dde |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than watch
projectDirand all of its descendants, this pull request changes it so that the CLI watchesprojectDirshallowly and watches everything inwatchPathsdeeply. This means that new relevant items are detected, such as./pages, while ignoring anything beyond that, such as ignoring the descendants of./node_modules.I am pretty sure everything else behaves the same, but it is hard to tell. I did come across some things that seem strange while testing, but it appears that these existed before, so it is not a regression. Here are the issues:
CHANGELOG.mdis added after starting the local site../docs/intro.md, then removing/renaming it causes an error until it is returned.moonwave.toml, but it does not matter because it is always set totrue:moonwave/cli/src/prepareProject.ts
Line 140 in 6b24dde
I am curious as to where the program says to watch changes to
./src/./libsince these are not included inwatchPaths.On a side note, I think
moonwave.jsonis not mentioned anywhere on the website, even though it is valid as the fallback configuration file ifmoonwave.tomlis missing.Closes #178