Open
Conversation
This commit extends the current span to include the transfer of the HTTP response body rather than ending it when the headers complete. This provides a fuller, more accurate picture of the HTTP request. This is implemented using a `TransformStream` on the HTTP response body that acts as a pass-through and only calling `span.end()` once the stream has completed.
aron
force-pushed
the
instrument-fetch-end-to-end-root
branch
from
f88ff38 to
11bca7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
Currently the span associated with a fetch() HTTP request is closed once the headers have been received and the promise resolves with a
Responseobject. However this does not account for the time taken to stream the response body back to the client resulting in an inconsistent span.This commit extends the current span to include the transfer of the HTTP response body rather than ending it when the headers complete. This provides a fuller, more accurate picture of the HTTP request.
This is implemented using a
TransformStreamon the HTTP response body that acts as a pass-through and only callingspan.end()once the stream has completed.