Support for Oracle Database#67
Merged
evangelosmeklis merged 1 commit intoevangelosmeklis:mainfrom Jan 25, 2025
Merged
Conversation
Collaborator
|
Tested from my side, seems to work as supposed to. @evangelosmeklis could check it also and we can proceed to merge. A new tag could be released also as we have multiple features released, since the latest. |
evangelosmeklis
approved these changes
Jan 25, 2025
Owner
evangelosmeklis
left a comment
evangelosmeklis
left a comment
There was a problem hiding this comment.
seems cool! thanks a lot for submitting this and contributing to PeepDB
Contributor
Author
|
Thank you! Just a quick note – the main description in the README file should be updated to include support for MSSQL and Oracle DB as well. |
Owner
|
@Peter-Fayez95 yeap will change it thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.