Add support for communicating with CDJ-3000 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
Does anything break if it’s just always set? |
Author
I have tested it with a CDJ-3000 and works perfectly. I wasn't able to test it with other CDJs or other setups since I don't have access to them but normally everything should work fine. |
Owner
|
I’ll ask around in the dysentery Zulip. I might not be able to get to this for a week or so. Got a lot going on IRL right now! thanks again for opening this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communication with a CDJ-3000 is different, see https://djl-analysis.deepsymmetry.org/djl-analysis/startup.html#startup-3000
This PR introduces the needed changes for this different communication while allowing backwards-compatibility.