Optimization: reuse a controller for rendering #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes prompt rendering by instantiating and configuring a single controller once instead of recreating it on every render call.
- Instantiate
ApplicationControllerand configure its view path ininitialize - Update
renderto reuse the cached controller instance
Comments suppressed due to low confidence (1)
lib/action_prompt/renderer.rb:8
- Add or update tests to cover multiple sequential
rendercalls to ensure caching the controller doesn’t introduce unintended side effects.
def render(template_name, locals: {})
Comment on lines
3
to
+9
| def initialize | ||
| # NOOP | ||
| @controller = ApplicationController.new | ||
| @controller.prepend_view_path(Rails.root.join("app", "prompts")) | ||
| end | ||
|
|
||
| def render(template_name, locals: {}) | ||
| controller = ApplicationController.new | ||
| controller.prepend_view_path(Rails.root.join("app", "prompts")) | ||
| controller.render_to_string(template: template_name, locals: locals, layout: false) | ||
| @controller.render_to_string(template: template_name, locals: locals, layout: false) |
There was a problem hiding this comment.
Consider using Rails’ built-in renderer (ApplicationController.renderer)—it’s thread-safe and avoids manually instantiating controllers.
Copilot uses AI. Check for mistakes.
Comment on lines
+4
to
+9
| @controller = ApplicationController.new | ||
| @controller.prepend_view_path(Rails.root.join("app", "prompts")) | ||
| end | ||
|
|
||
| def render(template_name, locals: {}) | ||
| controller = ApplicationController.new | ||
| controller.prepend_view_path(Rails.root.join("app", "prompts")) | ||
| controller.render_to_string(template: template_name, locals: locals, layout: false) | ||
| @controller.render_to_string(template: template_name, locals: locals, layout: false) |
There was a problem hiding this comment.
Reusing a single controller instance may introduce state leaks or thread-safety issues under concurrent requests; consider using a fresh renderer per call or a thread-local instance.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A controller used to render a prompt template should be a renderer’s attribute instead of being set up for each rendering.