fix(sdk): resolve getResource by requested type#2171
Open
thorthelegend99 wants to merge 1 commit intoevent-catalog:mainfrom
Open
fix(sdk): resolve getResource by requested type#2171thorthelegend99 wants to merge 1 commit intoevent-catalog:mainfrom
thorthelegend99 wants to merge 1 commit intoevent-catalog:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 018c436 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findFileByIdoptionally type-aware using resource folder matchinggetResourceintofindFileById@eventcatalog/sdkWhy
When multiple resource types share an id,
getService/getEvent-style calls could resolve the wrong resource because lookup was id-only.Validation
pnpm --filter @eventcatalog/sdk exec vitest run src/test/resources.test.tspnpm --filter @eventcatalog/sdk exec vitest run src/test/services.test.ts -t "returns the given service id from EventCatalog and the latest version when no version is given"