Skip to content

Implement operators as functions#21

Draft
MidnightDesign wants to merge 4 commits intomasterfrom
operators-as-functions
Draft

Implement operators as functions#21
MidnightDesign wants to merge 4 commits intomasterfrom
operators-as-functions

Conversation

@MidnightDesign
Copy link
Contributor

No description provided.

@MidnightDesign MidnightDesign requested a review from rieschl March 25, 2024 19:43
rieschl
rieschl previously approved these changes Mar 25, 2024
Copy link
Member

@rieschl rieschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of bc breaks in there?

@MidnightDesign
Copy link
Contributor Author

lots of bc breaks in there?

I was very deliberate when deciding what's @api and what's @internal originally. All of the removed classes were @internal ... except for Negative where I forgot to add it. : /

Widening the return types of the Expr::*() methods isn't ideal though. I should have never made them that narrow.

Let me think about how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants