This repository was archived by the owner on Jul 2, 2024. It is now read-only.
EVG-17465 Install react-virtualized and source map explorer #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
suggested changes
Aug 25, 2022
package.json
Outdated
| "react-dom": "18.2.0", | ||
| "react-router-dom": "6.3.0" | ||
| "react-router-dom": "6.3.0", | ||
| "react-virtualized": "^9.22.3" |
Collaborator
There was a problem hiding this comment.
Is it worth pinning this dependency?
Collaborator
Author
There was a problem hiding this comment.
Pinned for consistency
| permissions: public-read | ||
| display_name: storybook_assets_map_ | ||
|
|
||
| attach-source-map: |
Collaborator
There was a problem hiding this comment.
Looks like this file is not getting uploaded exactly correctly (here)
Collaborator
Author
There was a problem hiding this comment.
I updated the content_type it should work now 🤞
sophstad
approved these changes
Aug 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-17465
Description
Since i am trying to avoid merge conflicts i tried to add as minimal code changes to this as possible but i have attached a video demonstrating react-virtualized being imported.
esbuild and rollup which are used under the hood by vite do not perform dead code removal and react-virtualized has a bogus import so i added a vite plugin that handles manually removing the dead code.
See.
bvaughn/react-virtualized#1635
bvaughn/react-virtualized#1632
Screenshots
Screen.Recording.2022-08-24.at.11.45.46.AM.mov
Testing
Created a demo app with a virtualized list.