Fix: allow serving assets from theme public directories #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR updates the
imageProcessor
service to support serving static assets located in theme-specific public folders (e.g., themes/my-theme/public/image.png).
Why is this needed?
Previously, the /images route only looked for assets in the root media/ and public/ directories. This prevented theme developers from including custom assets within their theme structure, causing 404 errors for theme-specific images.
How was this implemented?
Modified
packages/evershop/src/modules/cms/services/imageProcessor.ts
.
Added logic to dynamically scan the themes/ directory.
Included themes/<theme_name>/public/ paths in the asset search priority list.
How to test?
Create a theme directory: themes/test-theme/public/.
Place an image file there (e.g., test-image.png).
Access the image via the browser or API: /assets/test-image.png.
The image should load correctly instead of returning a 404 error.