Open
Conversation
The constructor on line 42 was defined as GeoArray(A) referencing undefined variables f and crs. Fixed to GeoArray(A, f, crs::String) matching the docstring above it. Added tests for all constructor variants. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184
The constructor on line 42 of
src/geoarray.jlwas defined asGeoArray(A), referencing undefined variablesfandcrs. Based on the docstring above it, this should be a 3-argument constructor:GeoArray(A, f, crs::String).Changes:
src/geoarray.jl: FixedGeoArray(A)→GeoArray(A, f, crs::String)test/test_geoarray.jl: Added tests for all constructor variants (array-only, AffineMap+String CRS, AffineMap-only, AffineMap+WKT CRS, AffineMap+String CRS+metadata)