fix: correct regex for folder names containing 'index'#3271
Open
RamiNoodle733 wants to merge 1 commit intoevidence-dev:mainfrom
Open
fix: correct regex for folder names containing 'index'#3271RamiNoodle733 wants to merge 1 commit intoevidence-dev:mainfrom
RamiNoodle733 wants to merge 1 commit intoevidence-dev:mainfrom
Conversation
The regex /\/?index/g was removing all occurrences of 'index' from the entire path, not just the trailing '/index' from the filename. This caused folder names containing 'index' (e.g., 'something-momentum-index') to be corrupted during build. Changed to /\/?index$/ to only match '/index' at the end of the path. Fixes evidence-dev#3263
RamiNoodle733
requested a deployment
to
Approval required to run action on external PR
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
When a page folder name contains the word "index" (e.g., something-momentum-index), the build fails because the route generation logic incorrectly strips "index" from the folder name, not just from the index.md filename.
Root Cause
The regex
/\/?index/gremoves all occurrences of "index" from the entire path, not just the trailing/indexfrom the filename.Solution
Changed the regex from
/\/?index/gto/\/?index$/to only match/indexat the end of the path.Changes
sites/example-project/src/pages/api/[...route]/evidencemeta.json/+server.jsto fix the regexFixes #3263