Skip to content

Fix parquet extra for pandas <2 #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mike0sv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix parquet extra for pandas <2 #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ dependencies = [
"plotly>=5.10.0,<6",
"statsmodels>=0.12.2",
"scikit-learn>=1.1.1",
"pandas[parquet]>=1.3.5",
"pandas>=1.3.5",
"pyarrow>=14.0.1",
Copy link

@mikeweltevrede mikeweltevrede Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mike0sv - why did you choose this lowest version? Was there a specific functionality implemented in this version that evidently needs to use. Asking because I think it would be great to support as many versions as possible while keeping the functionality the same. This way, users don't have their dependencies unnecessarily updated if there is no reason to.

Copy link
Collaborator Author

@mike0sv mike0sv Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, need to find PR where we choose it and see what was it about. We recently switched to uv, so we need to look for old setup.py git history

Copy link
Collaborator Author

@mike0sv mike0sv Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ad4dae5

Copy link

@mikeweltevrede mikeweltevrede Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was not clear and explicit (I just put the comment on the line of pyarrow). I meant for the version of pyarrow specifically, not pandas

"numpy>=1.22.0",
"nltk>=3.6.7",
"scipy>=1.10.0",
Expand Down
2 changes: 1 addition & 1 deletion requirements.min.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
plotly==5.10.0
statsmodels==0.12.2
scikit-learn==1.1.1
pandas[parquet]==1.3.5
pandas==1.3.5
numpy==1.22.0
nltk==3.6.7
scipy==1.10.0
Expand Down