Support tox-uris in the form tox://0123ABCD?name=robin&message=hello#1293
Draft
robinlinden wants to merge 2 commits intoevilcorpltd:masterfrom
Draft
Support tox-uris in the form tox://0123ABCD?name=robin&message=hello#1293robinlinden wants to merge 2 commits intoevilcorpltd:masterfrom
tox://0123ABCD?name=robin&message=hello#1293robinlinden wants to merge 2 commits intoevilcorpltd:masterfrom
Conversation
`tox:0123ABCD` is still supported, but it can't have query-parameters as it's an opaque uri. `tox://0123ABCD` is a hierarchical uri and supports all the fancy features.
robinlinden
force-pushed
the
tox-uri-2
branch
from
3fa2a35 to
a9fc062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox:0123ABCDis still supported, but it can't have query-parameters asit's an opaque uri.
tox://0123ABCDis a hierarchical uri and supportsall the fancy features.
This is TokTok/qTox#516, but for aTox. Seems like a very nice feature to have to e.g. name yourself somewhat correctly when a QR-code is scanned, as well as providing a message saying where the contact request is coming from:
tox://76518406F6A9F2217E8DC487CC783C25CC16A15EB36FF32E335A235342C48A39218F515C39A6?message=hello%20from%20robinli.eu&name=echobot