Improved Call screen, rewritten CallManager with 4 calll states #1334
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private fun playConnecting() { | ||
| val audioAttrContext = | ||
| if (Build.VERSION.SDK_INT >= 30) { |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| } | ||
| } | ||
|
|
||
| fun presentTime(hours: Long, minutes: Int, seconds: Int, nanoseconds: Int): String { |
Check warning
Code scanning / detekt
Function parameter is unused and should be removed. Warning
| else -> "" | ||
| } | ||
| sf += if (hours == 0L) { | ||
| String.format("%02d:%02d", minutes, seconds) |
Check warning
Code scanning / detekt
Implicit default locale used for string processing. Consider using explicit locale. Warning
| @Inject | ||
| lateinit var eventListenerCallbacks: EventListenerCallbacks | ||
|
|
||
| val screenTimerMs = 1000L |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| sf += if (hours == 0L) { | ||
| String.format("%02d:%02d", minutes, seconds) | ||
| } else { | ||
| String.format("%01d:%02d:%02d", hours, minutes, seconds) |
Check warning
Code scanning / detekt
Implicit default locale used for string processing. Consider using explicit locale. Warning
| if (delta < 0) delta = 0 | ||
| storedFrameCount = new | ||
| // normal fps = screenTimerMs / CallManager.AUDIO_SEND_INTERVAL_MS = 50 | ||
| val asSymbol = if (delta > 25) { |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
1 participant
Addresses issues #1333