Conversation
Collaborator
|
Well... |
Copilot
AI
changed the title
[WIP] Add testing instructions for UI plugin in Figma to README
Add testing instructions for Figma plugin development to README
Jul 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive testing instructions for Figma plugin development to the README.md file, along with several CSS utility class improvements in React components.
- Addition of "Testing the Plugin in Figma" section with setup and usage instructions
- Updates to Tailwind CSS classes, replacing separate
h-andw-utilities with the more concisesize-utility - Strategic placement of testing documentation between build and contributing sections
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Readme.md | Adds complete testing section with plugin setup and running instructions |
| src/ui/components/SettingsButton.tsx | Updates button styling to use size-6 instead of h-6 w-6 |
| src/ui/components/SelectionContent.tsx | Updates container div to use size-full instead of h-full w-full |
| src/ui/components/LayeredColorPreviewIcon.tsx | Updates icon container to use size-4 instead of h-4 w-4 |
| src/ui/components/HelpLink.tsx | Updates link styling to use size-6 instead of h-6 w-6 |
| src/ui/components/ContrastSample.tsx | Partially updates small size variant to use size-9 instead of h-9 w-9 |
src/ui/components/ContrastSample.tsx
Outdated
| <p | ||
| className={clsx( | ||
| size === 'small' ? 'h-9 w-9 text-xxs' : 'h-13 w-13 text-base', | ||
| size === 'small' ? 'size-9 text-xxs' : 'h-13 w-13 text-base', |
There was a problem hiding this comment.
Inconsistent CSS utility class usage. The 'small' size uses 'size-9' while the default case still uses 'h-13 w-13'. For consistency with the other changes in this PR, consider using 'size-13' for the default case as well.
Suggested change
| size === 'small' ? 'size-9 text-xxs' : 'h-13 w-13 text-base', | |
| size === 'small' ? 'size-9 text-xxs' : 'size-13 text-base', |
Co-authored-by: mikhin <38258318+mikhin@users.noreply.github.com>
8c795d1 to
9b5e746
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive "Testing the Plugin in Figma" section to the README.md file to help developers test the plugin locally during development.
What's Added
The new section includes:
Setting up the Plugin for Testing
manifest.jsonRunning the Plugin
Cmd/Ctrl + /and search)Placement
The section is strategically placed after the "Build" section and before the "Contributing" section, providing a natural flow from building to testing to contributing.
Benefits
This addition will help developers:
The instructions are concise but comprehensive, following the existing documentation style in the README.
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.