Conversation
|
There is a slight glitch on hover on tooltip appearance. Not sure what is the cause. Trying to figure out |
|
Probably if drop preact/compat the size will be lower? |
|
|
||
| export const formatForOklchDisplay = (oklch: Oklch): string => { | ||
| return `${toPercent(oklch.l)} ${clearValue(oklch.c)} ${clearValue( | ||
| export const formatForOklchDisplay = (oklch: Oklch): string => `${toPercent(oklch.l)} ${clearValue(oklch.c)} ${clearValue( |
There was a problem hiding this comment.
Jfyi, looks a bit strange to mix preact migration with style fixes not related to the main issue
There was a problem hiding this comment.
i guess it happened when i changed eslint react to preact
Yes! It will be nice to avoid |
|
What is the final size? |
| plugins: ['preact', 'prettier', 'jsx-a11y', 'boundaries'], | ||
| rules: { | ||
| 'no-undef': 'off', | ||
| 'react/jsx-no-bind': 'off', |
There was a problem hiding this comment.
Minor issue: I'm not sure, but could we completely get rid of react in any form? Remove or rename this prop?
Otherwise, good job, thank you 👍
There was a problem hiding this comment.
Actually we cant. There is no such rule as preact/jsx-no-bind. I have tried to remove it but es lint tests don't pass
package.json
Outdated
| "dependencies": { | ||
| "@figma/plugin-typings": "^1.79.0", | ||
| "@floating-ui/dom": "^1.7.3", | ||
| "@floating-ui/react": "^0.25.2", |
349.46 kB comparing to react with 497.47 kB |
3 participants
React
dist/api.js 15.76 kB │ gzip: 6.17 kB
dist/index.html 497.47 kB │ gzip: 251.45 kB
Preact
dist/api.js 15.76 kB │ gzip: 6.17 kB
dist/index.html 354.69 kB │ gzip: 207.84 kB