Conversation
0ec60d1 to
4f806e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presenters are not dead yet 🙂 Let's make sure this gem is up to date and works with modern Rails and Ruby.
Changes
Updated rendering benchmark results:
ruby 3.3.6 (2024-11-05 revision 75015d4c1f) +YJIT [arm64-darwin23] Calculating ------------------------------------- rumble 146.705k (± 4.1%) i/s (6.82 μs/i) - 1.464M in 9.999849s erb_hash 118.546k (± 6.2%) i/s (8.44 μs/i) - 1.183M in 10.028902s erb_binding 68.074k (± 5.1%) i/s (14.69 μs/i) - 681.296k in 10.036169s raw_erb_template 744.910k (± 0.5%) i/s (1.34 μs/i) - 7.519M in 10.094407s Comparison: raw_erb_template: 744910.3 i/s rumble: 146705.3 i/s - 5.08x slower erb_hash: 118545.7 i/s - 6.28x slower erb_binding: 68074.5 i/s - 10.94x slower