Skip to content

Back to business#19

Closed
palkan wants to merge 1 commit intomasterfrom
main
Closed

Back to business#19
palkan wants to merge 1 commit intomasterfrom
main

Conversation

@palkan
Copy link
Member

@palkan palkan commented Jan 10, 2025

Presenters are not dead yet 🙂 Let's make sure this gem is up to date and works with modern Rails and Ruby.

Changes

  • Drop support for Rails <7 and Ruby <3
  • Migrate to RSpec (Minitest is still used for Minitest-related tests); no more Test::Unit
    • Use ammeter for generator tests
  • Migrate to GitHub Actions
  • Add RuboCop
  • Add documentation linting tools (CI only)
  • Configured Lethook

Updated rendering benchmark results:

ruby 3.3.6 (2024-11-05 revision 75015d4c1f) +YJIT [arm64-darwin23]

Calculating -------------------------------------
              rumble    146.705k (± 4.1%) i/s    (6.82 μs/i) -      1.464M in   9.999849s
            erb_hash    118.546k (± 6.2%) i/s    (8.44 μs/i) -      1.183M in  10.028902s
         erb_binding     68.074k (± 5.1%) i/s   (14.69 μs/i) -    681.296k in  10.036169s
    raw_erb_template    744.910k (± 0.5%) i/s    (1.34 μs/i) -      7.519M in  10.094407s

Comparison:
    raw_erb_template:   744910.3 i/s
              rumble:   146705.3 i/s - 5.08x  slower
            erb_hash:   118545.7 i/s - 6.28x  slower
         erb_binding:    68074.5 i/s - 10.94x  slower

@palkan palkan force-pushed the main branch 7 times, most recently from 0ec60d1 to 4f806e7 Compare January 10, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant