Conversation
palkan
force-pushed
the
refactor/inline-v2
branch
from
09df778 to
2ceab71
Compare
palkan
force-pushed
the
refactor/inline-v2
branch
from
2ceab71 to
c760394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Improve inlined templates support.
What changes did you make? (overview)
Is there anything you'd like reviewers to focus on?
Updated benchmark results:
$ ruby 3.3.6 (2024-11-05 revision 75015d4c1f) +YJIT [arm64-darwin23] Calculating ------------------------------------- rumble 141.823k (± 7.8%) i/s (7.05 μs/i) - 1.407M in 10.006149s erb_hash 254.596k (± 4.3%) i/s (3.93 μs/i) - 2.558M in 10.068461s raw_erb_template 707.835k (± 3.5%) i/s (1.41 μs/i) - 7.104M in 10.050222s Comparison: raw_erb_template: 707835.2 i/s erb_hash: 254596.2 i/s - 2.78x slower rumble: 141823.2 i/s - 4.99x slowerChecklist