Conversation
kindermax
force-pushed
the
federated-node-transitive-requires-validation
branch
3 times, most recently
from
98110b0 to
3201dae
Compare
…ction time When a Link declares requires=['a', 'b'] but field 'b' itself has @requires(fields='c'), the Link's SDL @requires must also include 'c' — otherwise Apollo Router never sends 'c', causing a KeyError at runtime. GraphInit._validate_link_requires() now detects this mismatch during Graph() construction and raises a ValueError with a suggested fix, making the class of bug impossible to deploy undetected.
kindermax
force-pushed
the
federated-node-transitive-requires-validation
branch
from
3201dae to
7c778d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Link declares
requires=['a', 'b']but field'b'itself has@requires(fields='c'), the Link's SDL@requiresmust also include'c'—otherwise Apollo Router never sends
'c', causing a KeyError at runtime in the link resolver.GraphInit._validate_link_requires()now detects this mismatch duringGraph()construction and raises aValueErrorwith a suggested fix, makingthe class of bug impossible to deploy undetected.