Open
Conversation
kindermax
commented
Feb 20, 2023
| def wrapper(field_names, *args): | ||
| def wrap_proc(start_time, field_name, proc): | ||
| def _proc_wrapper(*args): | ||
| result = proc(*args) |
Collaborator
Author
There was a problem hiding this comment.
passing start_time from above allows to track subgraph execution + proc execution time.
Collaborator
Author
There was a problem hiding this comment.
maybe it makes sense to place start_time = time.perf_counter() inside _proc_wrapper but then we are (probably) loosing subgraph(low-level graph) data exection time
added 2 commits
March 25, 2023 14:46
059557a to
cd7fddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix aims to improve subquery fields tracking.
Problem
Let's consider case when several fields are resolved using same subgraph. In this case both fields will have the same duration (from superSlowField), but this is wrong.
In production it looks like this:
Solution
We need to track each field resolver individually. In this pr
wrap_procwill wrap field'sprocfunction (proc function is basically a function with@definedecorator on it) so instead of trackingresult = result_proc()which is a_create_result_procwe will track eachprocindividually, see:hiku/hiku/sources/graph.py
Lines 50 to 58 in 8b5598c
Result
Simple example which prints
observeargsBefore:
After: