Cross compile for Scala 3#684
Merged
Z1kkurat merged 4 commits intoevolution-gaming:masterfrom Mar 14, 2025
Merged
Conversation
core/src/main/scala-3/com/evolutiongaming/kafka/flow/persistence/compression/CodecOps.scala
Outdated
Show resolved
Hide resolved
3 tasks
johanmast
force-pushed
the
scala3
branch
2 times, most recently
from
3288f36 to
76a1a73
Compare
grzegorz-bielski
approved these changes
Mar 12, 2025
Z1kkurat
reviewed
Mar 12, 2025
| case (_, y) => y | ||
| } | ||
| ) | ||
| private[this] implicit val pickMinOffset: CommutativeMonoid[Option[Offset]] = |
Contributor
There was a problem hiding this comment.
can we leave passing this explicitly? I'm worried about it slipping somewhere here it shouldn't belong, and it's not a universally correct implementation
Contributor
Author
There was a problem hiding this comment.
It results in a compile error on Scala 3, but I'll take another look
Contributor
Author
There was a problem hiding this comment.
Fixed now, it required adding using for Scala 3
Contributor
There was a problem hiding this comment.
TIL using actually works for argument lists in Scala 2.
...src/main/scala/com/evolutiongaming/kafka/flow/persistence/compression/HeaderAndPayload.scala
Show resolved
Hide resolved
grzegorz-bielski
approved these changes
Mar 12, 2025
Z1kkurat
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross compile for Scala 3, except for the journal module, because there is no Scala 3 version of kafka-journal.