Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated methods across multiple schema and key management classes to clean up the codebase. The deprecated methods were marked for removal since versions 5.0.6 and 6.1.3, and their removal supports API consolidation by forcing users to use newer method variants with explicit parameters.
Key changes:
- Removes deprecated factory methods that lacked explicit table name parameters
- Eliminates deprecated key management methods that didn't use proper logging prefixes
- Consolidates API surface by removing redundant method overloads
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SnapshotSchema.scala | Removes deprecated of method without explicit table name parameter |
| KeySchema.scala | Removes deprecated of method without explicit table name parameter |
| JournalSchema.scala | Removes deprecated of method without explicit table name parameter |
| KeysOf.scala | Removes deprecated memory and apply methods lacking proper logging support |
| Keys.scala | Removes deprecated apply method without LogPrefix requirement |
| KeyDatabase.scala | Removes deprecated keysOf method without LogPrefix parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.