Skip to content

Conversation

@davey91
Copy link
Contributor

@davey91 davey91 commented Jan 6, 2026

Created a TimerFlow that combines unloadOrphaned and persistPeriodically, extracted some duplicated code in the process too. The TimerFlowOfSpecs are changed as in that they test the original timerFlows, with the new persistPeriodicallyAndUnloadOrphaned added.

daveybrouwer added 2 commits January 6, 2026 11:11
- Made the code a bit more uniform
- Moved flushOnCancled a bit lower
- Added documentation for persistPeriodicallyAndUnloadOrphaned
- Deduplicating some code
- Ordering in the for yield
- Less power
- Extracted some more vals
- Additional clarity
- Removed nowarn
- All specs now test both timerFlows
- All persistPeriodically specs now test both timerFlows
- Slowly implementing a TimerFlow that can unload and persist, but I think there's still some flaws
- Also added the persistingAndUnloading TimerFlow to persistPeriodically test, seems to succeed without any additional logic needed
- Reworking the specs to support multiple timerFlows
- Start with creating a new timerFlowOf that unloads and persists
@Z1kkurat Z1kkurat merged commit e76c63e into evolution-gaming:master Jan 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants