update Kafka client to 4.0.0 #484
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setAndMetadata], consumerGroupId: String)`
mr-git
commented
Apr 9, 2025
| for { | ||
| _ <- actions.add(Action.PartitionsAssignedEnter) | ||
| _ <- assigned0.complete(()) | ||
| _ <- assigned1.get |
Contributor
Author
There was a problem hiding this comment.
removed as it creates dead-lock (1)
|
|
||
| _ <- assigned0.get.toResource | ||
| _ <- consumer.topics.toResource | ||
| _ <- assigned1.complete(()).toResource |
Contributor
Author
There was a problem hiding this comment.
removed as it creates dead-lock (2)
Comment on lines
+105
to
106
| Action.Topics, | ||
| Action.PollExit |
Contributor
Author
There was a problem hiding this comment.
this part exhibits race condition - sometimes these 2 actions are swapped
| lost0 <- Deferred[F, Unit].toResource | ||
| lost1 <- Deferred[F, Unit].toResource | ||
| listener = new RebalanceListener[F] { | ||
| listener = new RebalanceListener1WithConsumer[F] { |
Contributor
Author
There was a problem hiding this comment.
I am not sure, if this is the correct way how to migrate this unit-test
Z1kkurat
reviewed
May 19, 2025
| Action.PartitionsLostEnter, | ||
| Action.Topics, | ||
| Action.PartitionsLostExit, | ||
| Action.Topics, |
Contributor
There was a problem hiding this comment.
do we know why this has changed? this order seems weird to me
| compressionType = CompressionType.Lz4, | ||
| retries = 8, | ||
| maxInFlightRequestsPerConnection = 7, | ||
| partitionerClass = Some(classOf[DefaultPartitioner]), |
Contributor
There was a problem hiding this comment.
is this something related to changes in java kafka-clients model? I tried to find the corresponding change to ProducerConfig in this changeset but I couldn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka-clientsto v4.0.0RebalanceListener