Skip to content

Fix Fitnet.Contracts.AppHost build configuration#244

Closed
Copilot wants to merge 2 commits intofeature/setup_properly_aspirefrom
copilot/sub-pr-242-again
Closed

Fix Fitnet.Contracts.AppHost build configuration#244
Copilot wants to merge 2 commits intofeature/setup_properly_aspirefrom
copilot/sub-pr-242-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 26, 2026

📋 Description

The Fitnet.Contracts.AppHost.csproj was missing required Aspire AppHost properties, preventing proper compilation and runtime recognition by the Aspire SDK.

Changes Made

  • Added missing PropertyGroup settings:
    • ImplicitUsings and Nullable for modern C# features
    • IsAspireHost for Aspire SDK recognition (critical)
    • UserSecretsId for configuration management
  • Added SonarAnalyzer.CSharp package update for static analysis consistency
  • Aligned configuration with existing AppHost projects in Chapter 1 and Chapter 2
<PropertyGroup>
  <OutputType>Exe</OutputType>
  <ImplicitUsings>enable</ImplicitUsings>
  <Nullable>enable</Nullable>
  <IsAspireHost>true</IsAspireHost>
  <UserSecretsId>b4ef32d8-9e82-4dd1-b9a7-bc43e2c564e9</UserSecretsId>
</PropertyGroup>

📦 PR Includes

  • Bug fix 🐛
  • Feature added 🆕
  • Code refactor 🔄
  • Documentation update 📚
  • Tests added/updated 🧪
  • Other: (describe)

🚫 PR Does Not Include

  • Breaking changes ❌
  • Major architectural changes 🏗️
  • Unrelated features/tasks 🚫

💡 Additional Notes

Maintains SDK version 13.0.0 to align with Chapter 3's centralized package management in Directory.Packages.props.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: kamilbaczek <74410956+kamilbaczek@users.noreply.github.com>
@kamilbaczek kamilbaczek marked this pull request as ready for review January 26, 2026 21:20
Copilot AI changed the title [WIP] Fix build issue and move aspire to proper directory Fix Fitnet.Contracts.AppHost build configuration Jan 26, 2026
Copilot AI requested a review from kamilbaczek January 26, 2026 21:21
@kamilbaczek kamilbaczek deleted the copilot/sub-pr-242-again branch January 27, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants