Skip to content

Update to use Rust 1.34 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2019
Merged

Update to use Rust 1.34 #1

merged 2 commits into from
Mar 23, 2019

Conversation

maur1th
Copy link
Contributor

@maur1th maur1th commented Mar 17, 2019

Features

Thanks to rust-lang/rust#58051 there is no need to use nightly anymore.

  • Upgrade to Rust 1.34; which is still in beta but no code change should be needed when it's released
  • Fix build warnings
  • rustfmt on the codebase

@maur1th maur1th changed the title Update to use 1.34 Update to use Rust 1.34 Mar 17, 2019
evq
evq approved these changes Mar 23, 2019
View reviewed changes
Copy link
Owner

@evq evq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for the PR! rustfmt output seems more reasonable for heavily nested macros that are common in nom than I remember in the past 👍

@evq evq merged commit 49fceec into evq:master Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evq evq evq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maur1th @evq