-
Notifications
You must be signed in to change notification settings - Fork 229
build(deps): remove unecessary replace main go.mod #2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the project's dependency management by removing a previously necessary 'replace' directive in the 'go.mod' file. This change allows the project to directly utilize the official 'celestiaorg/go-header' module, simplifying the build configuration and reflecting the integration of upstream changes or the resolution of prior dependency conflicts.
Highlights
- Dependency Management: Removed a temporary 'replace' directive in the 'go.mod' file for the 'github.com/celestiaorg/go-header' module.
- Module Resolution: The project now directly uses the official 'github.com/celestiaorg/go-header' module at version 'v0.7.2', indicating that the temporary override is no longer needed.
- Build System Clean-up: Cleaned up the 'go.sum' file by removing entries related to the temporary 'julienrbrt/go-header' fork and adding entries for the official 'celestiaorg/go-header' module.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes a temporary replace
directive from the go.mod
file that was pointing to a fork of go-header
. This is a good dependency hygiene practice, and the corresponding changes in go.sum
are also correct. The change is approved. As a minor note, the word 'unnecessary' is misspelled in the pull request title.
Code ReviewThank you for this cleanup PR! I've reviewed the changes and here's my feedback: ✅ SummaryThis PR removes a temporary replace directive for Code Quality & Best Practices ✅
Potential Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2675 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 76 76
Lines 7658 7658
=======================================
Hits 5098 5098
Misses 2093 2093
Partials 467 467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔍 Code ReviewSummaryThis PR removes an unnecessary replace directive from the main go.mod file that was previously blocking PR #2638. The change is straightforward and aligns with cleaning up technical debt. ✅ Strengths
|
This PR was blocked but got merged: #2638.
It isn't bad to merge it, but we are relying on a fork of go-header for the apps until celestiaorg/go-header#347 is merged.
Let's delete it in the main go.mod