Skip to content

chore: fix some function names in comment #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

chore: fix some function names in comment #2737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/crates/types/src/proto/evnode.v1.services.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2558,7 +2558,7 @@ pub mod config_service_client {
.insert(GrpcMethod::new("evnode.v1.ConfigService", "GetNamespace"));
self.inner.unary(req, path, codec).await
}
/// GetSequencerInfo returns information about the sequencer
/// GetSignerInfo returns information about the signer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This comment fix is correct, but this file is auto-generated (// This file is @generated by prost-build.). Manually editing generated files should be avoided to prevent inconsistencies. Please regenerate the files from the source .proto definitions using the project's build scripts instead.

pub async fn get_signer_info(
&mut self,
request: impl tonic::IntoRequest<()>,
Expand Down Expand Up @@ -2601,7 +2601,7 @@ pub mod config_service_server {
tonic::Response<super::GetNamespaceResponse>,
tonic::Status,
>;
/// GetSequencerInfo returns information about the sequencer
/// GetSignerInfo returns information about the signer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the previous comment, this change is correct but is applied to a generated file. Please consider regenerating the proto files instead of editing them manually to maintain consistency.

async fn get_signer_info(
&self,
request: tonic::Request<()>,
Expand Down
4 changes: 2 additions & 2 deletions types/pb/evnode/v1/v1connect/config.connect.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading