Skip to content

Fix linting #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewanwm merged 7 commits into from
Aug 28, 2025
Merged

Fix linting #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7adec6
Update Lint-cpp-main.yaml
ewanwm Aug 28, 2025
e3687e5
Update Lint-cpp-main.yaml
ewanwm Aug 28, 2025
ffe6bef
Update Lint-cpp-main.yaml
ewanwm Aug 28, 2025
1259a0c
Update Lint-cpp-main.yaml
ewanwm Aug 28, 2025
b14b365
Update Lint-cpp-main.yaml
ewanwm Aug 28, 2025
6ca5029
Update Lint-cpp.yaml
ewanwm Aug 28, 2025
865d196
Update Lint-cpp.yaml
ewanwm Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/Lint-cpp-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
cpp-linter:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set Flags
run: export USE_CUDA=0
Expand All @@ -26,7 +26,7 @@ jobs:

- name: Configure CMake
# Configure CMake so we can get a compile_commands.json so that clang-tidy won't be angry about missing headers any more
run: cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DNT_ENABLE_BENCHMARKING=ON -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -B ${{github.workspace}} -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
run: cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DNT_ENABLE_BENCHMARKING=OFF -DNT_COMPILE_TESTS=OFF -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -B ${{github.workspace}} -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}

## horrible little hack to put spdlog include files somewhere that clang-tidy can find them
## it doesn't seem to like headers included by cpm
Expand All @@ -35,7 +35,7 @@ jobs:
cp -r _deps/spdlog-src/include/spdlog .
cp spdlog/spdlog* .

- uses: cpp-linter/cpp-linter-action@main
- uses: cpp-linter/cpp-linter-action@v2.15.0
id: linter
continue-on-error: true
env:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/Lint-cpp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
permissions: write-all
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set Flags
run: export USE_CUDA=0
Expand All @@ -28,16 +28,16 @@ jobs:

- name: Configure CMake
# Configure CMake so we can get a compile_commands.json so that clang-tidy won't be angry about missing headers any more
run: cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DNT_ENABLE_BENCHMARKING=ON -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -B ${{github.workspace}} -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}

run: cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DNT_ENABLE_BENCHMARKING=OFF -DNT_COMPILE_TESTS=OFF -DCMAKE_PREFIX_PATH=`python3 -c 'import torch;print(torch.utils.cmake_prefix_path)'` -B ${{github.workspace}} -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
## horrible little hack to put spdlog include files somewhere that clang-tidy can find them
## it doesn't seem to like headers included by cpm
- name: Move spdlog
run: |
cp -r _deps/spdlog-src/include/spdlog .
cp spdlog/spdlog* .

- uses: cpp-linter/cpp-linter-action@main
- uses: cpp-linter/cpp-linter-action@v2.15.0
id: linter
continue-on-error: true
env:
Expand Down