make baseline and density settable for DPpropagator#155
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v16.0.6
Click here for the full clang-tidy patch
diff --git a/nuTens/propagator/DP-propagator.hpp b/nuTens/propagator/DP-propagator.hpp
index 6d43330..5551f66 100644
--- a/nuTens/propagator/DP-propagator.hpp
+++ b/nuTens/propagator/DP-propagator.hpp
@@ -149 +149 @@ class DPpropagator : public Propagator
- [[nodiscard]] Tensor calculateProbs();
+ [[nodiscard]] Tensor calculateProbs() override;
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v16.0.6
Click here for the full clang-tidy patch
diff --git a/nuTens/propagator/DP-propagator.hpp b/nuTens/propagator/DP-propagator.hpp
index 6d43330..5551f66 100644
--- a/nuTens/propagator/DP-propagator.hpp
+++ b/nuTens/propagator/DP-propagator.hpp
@@ -149 +149 @@ class DPpropagator : public Propagator
- [[nodiscard]] Tensor calculateProbs();
+ [[nodiscard]] Tensor calculateProbs() override;
diff --git a/python/binding.cpp b/python/binding.cpp
index 4e62dfd..001794d 100644
--- a/python/binding.cpp
+++ b/python/binding.cpp
@@ -439,5 +439,4 @@ void initTesting(py::module &m)
- std::vector<std::vector<double>> ret = {
- {probs_returned[0][0], probs_returned[0][1], probs_returned[0][2]},
- {probs_returned[1][0], probs_returned[1][1], probs_returned[1][2]},
- {probs_returned[2][0], probs_returned[2][1], probs_returned[2][2]}
- };
+ std::vector<std::vector<double>> ret =
+ 0 = {{probs_returned[0][0], probs_returned[0][1], probs_returned[0][2]},
+ {probs_returned[1][0], probs_returned[1][1], probs_returned[1][2]},
+ {probs_returned[2][0], probs_returned[2][1], probs_returned[2][2]}};
Have any feedback or feature suggestions? Share it here.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
Bencher Report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.