Skip to content

fix so no leading comma in profile output#158

Merged
ewanwm merged 1 commit intomainfrom
fix/broken-profile-output
Sep 11, 2025
Merged

fix so no leading comma in profile output#158
ewanwm merged 1 commit intomainfrom
fix/broken-profile-output

Conversation

@ewanwm
Copy link
Owner

@ewanwm ewanwm commented Sep 11, 2025

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v16.0.6

Click here for the full clang-tidy patch
diff --git a/nuTens/utils/instrumentation.hpp b/nuTens/utils/instrumentation.hpp
index ff0a8be..2817b73 100644
--- a/nuTens/utils/instrumentation.hpp
+++ b/nuTens/utils/instrumentation.hpp
@@ -184 +184 @@ class InstrumentationTimer
-    InstrumentationTimer(std::string name) : _name(std::move(name)), _stopped(false)
+    InstrumentationTimer(std::string name) : _name(std::move(name)),
@@ -218 +218 @@ class InstrumentationTimer
-    bool _stopped;
+    bool _stopped{false};

Have any feedback or feature suggestions? Share it here.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

🐰 Bencher Report

Branchfix/broken-profile-output
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Const Density Oscillations/1024/1024📈 view plot
⚠️ NO THRESHOLD
1,908,822,874.00 ns
Const Density Oscillations/1024/1024_cv📈 view plot
⚠️ NO THRESHOLD
0.00 ns
Const Density Oscillations/1024/1024_mean📈 view plot
⚠️ NO THRESHOLD
1,908,975,160.25 ns
Const Density Oscillations/1024/1024_median📈 view plot
⚠️ NO THRESHOLD
1,908,819,512.50 ns
Const Density Oscillations/1024/1024_stddev📈 view plot
⚠️ NO THRESHOLD
4,901,869.84 ns
DP Propagator Const Density Oscillations/1024/1024📈 view plot
⚠️ NO THRESHOLD
1,016,132,950.00 ns
DP Propagator Const Density Oscillations/1024/1024_cv📈 view plot
⚠️ NO THRESHOLD
0.00 ns
DP Propagator Const Density Oscillations/1024/1024_mean📈 view plot
⚠️ NO THRESHOLD
1,016,148,896.31 ns
DP Propagator Const Density Oscillations/1024/1024_median📈 view plot
⚠️ NO THRESHOLD
1,015,671,301.50 ns
DP Propagator Const Density Oscillations/1024/1024_stddev📈 view plot
⚠️ NO THRESHOLD
2,734,738.70 ns
Vacuum Oscillations/1024/1024📈 view plot
⚠️ NO THRESHOLD
406,756,659.50 ns
Vacuum Oscillations/1024/1024_cv📈 view plot
⚠️ NO THRESHOLD
0.01 ns
Vacuum Oscillations/1024/1024_mean📈 view plot
⚠️ NO THRESHOLD
408,380,882.97 ns
Vacuum Oscillations/1024/1024_median📈 view plot
⚠️ NO THRESHOLD
407,315,480.50 ns
Vacuum Oscillations/1024/1024_stddev📈 view plot
⚠️ NO THRESHOLD
6,119,624.65 ns
🐰 View full continuous benchmarking report in Bencher

@ewanwm ewanwm merged commit 9cfd167 into main Sep 11, 2025
6 of 7 checks passed
@ewanwm ewanwm deleted the fix/broken-profile-output branch September 11, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants