Skip to content

Fix handling of {:system, "AWS_ROLE_ARN"}#44

Open
mbuffa wants to merge 5 commits intoex-aws:masterfrom
mbuffa:fix/config-role-arn-system
Open

Fix handling of {:system, "AWS_ROLE_ARN"}#44
mbuffa wants to merge 5 commits intoex-aws:masterfrom
mbuffa:fix/config-role-arn-system

Conversation

@mbuffa
Copy link

@mbuffa mbuffa commented Feb 26, 2026

Hello there,

Fixes #43

Also:

  • Updates Test/Dev dpeendencies (test suite wasn't running on Elixir 1.18)
  • Fixes the existing three failing tests (were missing proper mocks)
  • Fixes one deprecation
  • Addd a test to check that we correctly source AWS_ROLE_ARN from the system

@mbuffa mbuffa closed this Feb 26, 2026
@mbuffa
Copy link
Author

mbuffa commented Feb 26, 2026

Closing for rework

@mbuffa
Copy link
Author

mbuffa commented Feb 26, 2026

Ok. This should be better now.

Previously, we were calling auth.role_arn in get_security_credentials, so this function always expect it, so I ensured the upper call checks for role_arn presence.

Also simplified the code to make ExAws.Config.new load the Role ARN, and added a test to make sure the lib still works if we omit the role_arn arg.

@mbuffa mbuffa reopened this Feb 26, 2026
@mbuffa mbuffa changed the title Fix AssumeRoleCredentialsAdapter to properly source AWS_ROLE_ARN in AWS requests Fix handling of {:system, "AWS_ROLE_ARN"} Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using {:system, "AWS_ROLE_ARN"} causes a crash

1 participant