test: Add comprehensive tests for luthor_generator

.github/copilot-instructions.md

@@ -55,6 +55,18 @@ cd packages/luthor_generator/example
 dart run build_runner build -d
 ```
 
+### Testing luthor_generator
+The `luthor_generator` package has tests that use generated code from test fixtures:
+```bash
+cd packages/luthor_generator
+# Generate code for test fixtures
+dart run build_runner build --delete-conflicting-outputs
+# Run tests
+dart test
+```
+
+Tests are automatically run in CI which includes building the test fixtures.
+
 ### Documentation
 The documentation site is located in `./docs` and is built with Astro.
 
@@ -254,7 +266,7 @@ For each annotated class, generate:
 ### Supporting Code Generation
 1. Create annotation in `lib/src/annotations/validators/`
 2. Update generator to handle the new annotation
-3. Add tests for generated code
+3. Add tests for generated code in `test/` using fixtures
 4. Update example to demonstrate usage
 
 ## Resources

.github/workflows/unit_tests.yml

@@ -12,4 +12,6 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: ./.github/actions/setup-luthor
+      - name: Build generator test fixtures
+        run: cd packages/luthor_generator && dart run build_runner build --delete-conflicting-outputs
       - run: dpk run test

dpk.yaml

@@ -22,10 +22,16 @@ scripts:
     runInPackages:
       - packages/*
 
+  build:
+    command: dart run build_runner build --force-aot
+    runInPackages:
+      - packages/luthor_generator
+
   test:
     command: dart test
     runInPackages:
       - packages/luthor
+      - packages/luthor_generator
 
   publish:luthor:
     command: dart pub publish -f

packages/luthor_generator/build.yaml

@@ -3,5 +3,13 @@ builders:
     import: "package:luthor_generator/builder.dart"
     builder_factories: ["luthorBuilder"]
     build_extensions: { ".dart": [".luthor.g.part"] }
-    auto_apply: dependents
+    auto_apply: all_packages
     build_to: cache
+    applies_builders: ["source_gen:combining_builder"]
+
+targets:
+  $default:
+    sources:
+      - lib/**
+      - test/**
+      - $package$

packages/luthor_generator/example/build.yaml

@@ -0,0 +1,5 @@
+targets:
+  $default:
+    builders:
+      luthor_generator:luthor:
+        enabled: true

packages/luthor_generator/lib/helpers/validations/string_validations.dart

@@ -4,6 +4,19 @@ import 'package:analyzer/dart/element/element2.dart';
 import 'package:luthor_generator/checkers.dart';
 import 'package:luthor_generator/helpers/validations/base_validations.dart';
 
+/// Returns true if the string should be a raw string (contains backslashes)
+bool _shouldUseRawString(String value) {
+  return value.contains(r'\');
+}
+
+/// Formats a string literal, using raw string only if needed
+String _formatStringLiteral(String value) {
+  if (_shouldUseRawString(value)) {
+    return 'r"$value"';
+  }
+  return '"$value"';
+}
+
 String getStringValidations(FormalParameterElement param) {
   final buffer = StringBuffer();
 
@@ -239,7 +252,7 @@ void _checkAndWriteStartsWithValidation(
         .getField('messageFn')
         ?.toFunctionValue();
 
-    final params = <String>['r"$string"'];
+    final params = <String>[_formatStringLiteral(string!)];
     if (message != null) params.add("message: '$message'");
     if (messageFn != null) {
       params.add("messageFn: ${getQualifiedFunctionName(messageFn)}");
@@ -264,7 +277,7 @@ void _checkAndWriteEndsWithValidation(
         .getField('messageFn')
         ?.toFunctionValue();
 
-    final params = <String>['r"$string"'];
+    final params = <String>[_formatStringLiteral(string!)];
     if (message != null) params.add("message: '$message'");
     if (messageFn != null) {
       params.add("messageFn: ${getQualifiedFunctionName(messageFn)}");
@@ -289,7 +302,7 @@ void _checkAndWriteContainsValidation(
         .getField('messageFn')
         ?.toFunctionValue();
 
-    final params = <String>['r"$string"'];
+    final params = <String>[_formatStringLiteral(string!)];
     if (message != null) params.add("message: '$message'");
     if (messageFn != null) {
       params.add("messageFn: ${getQualifiedFunctionName(messageFn)}");

packages/luthor_generator/pubspec.yaml

@@ -19,5 +19,8 @@ dependencies:
   source_gen: ^4.0.0 # Configured via catalog
 
 dev_dependencies:
+  build_runner: ^2.4.0
+  freezed: ^3.0.3
+  json_serializable: ^6.7.0
   lint: ^2.3.0
   test: ^1.25.14

packages/luthor_generator/test/custom_validator_test.dart

@@ -0,0 +1,97 @@
+import 'package:luthor/luthor.dart';
+import 'package:test/test.dart';
+
+import 'fixtures/custom_validator_model.dart';
+
+void main() {
+  group('Custom Validator Tests', () {
+    test('should generate schema with custom validators', () {
+      expect($CustomValidatorModelSchema, isA<Validator>());
+    });
+
+    test('should validate @WithCustomValidator - valid case', () {
+      final validData = {
+        'customField': 'valid',
+        'matchField': 'test',
+        'confirmField': 'test',
+      };
+
+      final result = $CustomValidatorModelValidate(validData);
+
+      switch (result) {
+        case SchemaValidationSuccess(data: final model):
+          expect(model.customField, equals('valid'));
+        case SchemaValidationError(errors: final errors):
+          fail('Should not have validation errors: $errors');
+      }
+    });
+
+    test(
+      'should validate @WithCustomValidator - invalid case with custom message',
+      () {
+        final invalidData = {
+          'customField': 'invalid',
+          'matchField': 'test',
+          'confirmField': 'test',
+        };
+
+        final result = $CustomValidatorModelValidate(invalidData);
+
+        switch (result) {
+          case SchemaValidationSuccess(data: _):
+            fail('Should have validation error for custom validator');
+          case SchemaValidationError(errors: final errors):
+            expect(errors.keys, contains('customField'));
+            expect(errors['customField'], isNotNull);
+            expect(
+              (errors['customField']! as List).first,
+              equals('Value must be "valid"'),
+            );
+        }
+      },
+    );
+
+    test('should validate @WithSchemaCustomValidator - matching fields', () {
+      final validData = {
+        'customField': 'valid',
+        'matchField': 'password123',
+        'confirmField': 'password123',
+      };
+
+      final result = $CustomValidatorModelValidate(validData);
+
+      switch (result) {
+        case SchemaValidationSuccess(data: final model):
+          expect(model.matchField, equals('password123'));
+          expect(model.confirmField, equals('password123'));
+        case SchemaValidationError(errors: final errors):
+          fail('Should not have validation errors: $errors');
+      }
+    });
+
+    test(
+      'should validate @WithSchemaCustomValidator - non-matching fields',
+      () {
+        final invalidData = {
+          'customField': 'valid',
+          'matchField': 'password123',
+          'confirmField': 'different',
+        };
+
+        final result = $CustomValidatorModelValidate(invalidData);
+
+        switch (result) {
+          case SchemaValidationSuccess(data: _):
+            fail('Should have validation error for non-matching fields');
+          case SchemaValidationError(errors: final errors):
+            expect(errors.keys, contains('confirmField'));
+            expect(errors['confirmField'], isNotNull);
+            expect(
+              (errors['confirmField']! as List).first,
+              equals('Fields must match'),
+            );
+        }
+      },
+    );
+  });
+}

packages/luthor_generator/test/fixtures/annotated_model.dart

@@ -0,0 +1,23 @@
+import 'package:freezed_annotation/freezed_annotation.dart';
+import 'package:luthor/luthor.dart';
+
+part 'annotated_model.freezed.dart';
+part 'annotated_model.g.dart';
+
+@luthor
+@freezed
+abstract class AnnotatedModel with _$AnnotatedModel {
+  const factory AnnotatedModel({
+    @IsEmail() required String email,
+    @HasMin(8) @HasMax(100) required String password,
+    @HasMin(18) @HasMax(120) required int age,
+    @HasMinDouble(0.0) @HasMaxDouble(100.0) required double score,
+    @StartsWith('https://') String? website,
+    @EndsWith('.com') String? domain,
+    @Contains('test') String? testField,
+    @IsUuid() required String uuid,
+  }) = _AnnotatedModel;
+
+  factory AnnotatedModel.fromJson(Map<String, dynamic> json) =>
+      _$AnnotatedModelFromJson(json);
+}