Conversation
|
All contributors have signed the CLA ✍️ ✅ |
...pps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/css/styles.css
Outdated
Show resolved
Hide resolved
...pps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/adapters.js
Show resolved
Hide resolved
...pps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/adapters.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/scripts.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/scripts.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/utils.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/utils.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/utils.js
Outdated
Show resolved
Hide resolved
ui.apps/src/main/content/jcr_root/apps/etoolbox-backpack/admin/console/clientlibs/js/utils.js
Outdated
Show resolved
Hide resolved
.../main/content/jcr_root/apps/etoolbox-backpack/assets/clientlibs/backpack/js/delete-action.js
Outdated
Show resolved
Hide resolved
NastaLeo
requested review from
SkoryUladzislau,
abarmina,
aliakseiTraihel,
liubou-masiuk,
mhoroshko and
smiakchilo
| handler: () => deleteAction(config.data.packagePath) | ||
| } | ||
|
|
||
| ui.prompt(Granite.I18n.get('Delete'), message.html(), 'notice', [{text: Granite.I18n.get('Cancel')}, deleteBtn]); |
There was a problem hiding this comment.
(cosmetic) It does not make practical sense to wrap some of the labels into the i18n call. I know it was here before. Some people tend to wrap all the possible labels to kind of make sure that all the UI is translated. But as the project grows and more messages arrive, it goes out of hand. We are not managing i18n dictionaries in this project (and in the rest of EToolbox projects as well). So we might as well end up with a dialog prompt that has a text in English and the confirmation button in Arabic - what is it for?..
There was a problem hiding this comment.
Agree, what is your proposal? Can I retire i18n labels?
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| coral-icon:is([icon="backpack"], [icon="backpack-sites"]) { |
There was a problem hiding this comment.
❗ It was noticed long ago, that the Backpack's launcher icon stands out of all the rest of EToolbox'es icons (see the screenshot)
Please take care of it. Probably you need to just copy relevant styles from EToolbox Lists or the Link checker, etc. This is for uniformity
6 participants
No description provided.